Skip to content

Expose Text.Internal.Css#205

Merged
snoyberg merged 1 commit intoyesodweb:masterfrom
tolysz:export-css
Apr 19, 2017
Merged

Expose Text.Internal.Css#205
snoyberg merged 1 commit intoyesodweb:masterfrom
tolysz:export-css

Conversation

@tolysz
Copy link
Copy Markdown
Contributor

@tolysz tolysz commented Apr 18, 2017 •
edited
Loading

This change allows to fix yesod on 8.0.1 compiler by adding:

import Text.Internal.Css (Block(..))

to the failing modules
i.e. ones which die with:

ghc: panic! (the 'impossible' happened)
  (GHC version 8.0.1 for x86_64-unknown-linux):
        find_tycon
  Block        
  []           
               
Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug

fixes: #203

@snoyberg
Copy link
Copy Markdown
Member

snoyberg commented Apr 19, 2017

Can we at least add a Haddock comment to the top of these modules that they are only being exposed to work around a GHC bug, and that the modules should not be relied upon?

@tolysz
Expose Text.Css
08172d8 
This change allows to fix yesod on 8.0.1 compiler by adding:
```haskell
import Text.Css (Block(..))
```

to the failing modules
@tolysz
Copy link
Copy Markdown
Contributor Author

tolysz commented Apr 19, 2017

I hid them from haddock and moved them to Text.Internal.Css*

@tolysz tolysz changed the title Expose Text.Css Expose Text.Internal.Css Apr 19, 2017
@snoyberg snoyberg merged commit b3eea5e into yesodweb:master Apr 19, 2017
snoyberg added a commit that referenced this pull request Apr 19, 2017
@snoyberg
Version bump for #205
f170aa5
@snoyberg
Copy link
Copy Markdown
Member

snoyberg commented Apr 19, 2017 via email

@tolysz tolysz deleted the export-css branch April 19, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Block is not exported

2 participants

@tolysz @snoyberg