Skip to content

Add multiline literal aligned with bar#148

Merged
snoyberg merged 1 commit intoyesodweb:masterfrom
junjihashimoto:aligned-bar
Jan 22, 2015
Merged

Add multiline literal aligned with bar#148
snoyberg merged 1 commit intoyesodweb:masterfrom
junjihashimoto:aligned-bar

Conversation

@junjihashimoto
Copy link
Copy Markdown
Contributor

Add multiline literal aligned with bar.
This is inspired by heredoc of hackage.

@snoyberg
Copy link
Copy Markdown
Member

This looks good to me, I just have one question: why does the output (at least in the test) include \r characters?

This may be obvious, I'm just not fully awake right now.

@junjihashimoto
Copy link
Copy Markdown
Contributor Author

It is because the test file(TextSpec.hs) is DOS format whose newline is "\r\n".
I was surprised too.

snoyberg added a commit that referenced this pull request Jan 22, 2015
Add multiline literal aligned with bar
@snoyberg snoyberg merged commit 4c9afdf into yesodweb:master Jan 22, 2015
@snoyberg
Copy link
Copy Markdown
Member

Cool, thanks!

@junjihashimoto
Copy link
Copy Markdown
Contributor Author

Thanks too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants