Skip to content

Conversation

@ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Mar 9, 2022

This is based on #1338 but avoids overriding dependencies. The compatible targets are built and tested in CI, the others are marked as unbuildable and cabal-install will just skip them. EDIT: nothing is disabled any more

brandon-leapyear and others added 2 commits March 9, 2022 10:06
@parsonsmatt
Copy link
Collaborator

@aschmois this PR disables persistent-mongoDB because it depends (transitively) on cryptonite which hasn't been updated yet for GHC 9.2. I want to ping you on it so you're aware of why it isn't building.

@ysangkok
Copy link
Contributor Author

@parsonsmatt The PR now enables all packages since Cryptonite was updated.

@parsonsmatt
Copy link
Collaborator

Thank you!

@parsonsmatt
Copy link
Collaborator

Looks like we just need a patch level change on persistent and persistent-{mysql,mongoDB,postgresql,redis} for this one. I'll work up the changelog and cabal patches and have this released today.

@parsonsmatt parsonsmatt changed the base branch from master to matt/ghc-9.2 March 14, 2022 16:14
@parsonsmatt
Copy link
Collaborator

Going to merge into my branch and finish it off, thanks!

@parsonsmatt parsonsmatt merged commit 4634cbf into yesodweb:matt/ghc-9.2 Mar 14, 2022
@parsonsmatt parsonsmatt mentioned this pull request Mar 14, 2022
7 tasks
parsonsmatt added a commit that referenced this pull request Mar 14, 2022
* Allow GHC 9.2 for compatible packages (#1366)

* Add GHC 9.2 support

Co-authored-by: Janus <ysangkok@gmail.com>

* Enable Redis and MongoDB for 9.2

Co-authored-by: Brandon Chinn <brandon@leapyear.io>
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>

* test suite dependency version bounds are inherited from the library

* changelog, cabals

Co-authored-by: Janus Troelsen <ysangkok@gmail.com>
Co-authored-by: Brandon Chinn <brandon@leapyear.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants