Add RawPostgresql based on RawSqlite
#1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the discussion in #1298, it was found that external libraries which want to hook into Persistent's Postgres API are limited by their inability to access the postgresql-simple `Connection` which backs a Postgres `SqlBackend`. A similar issue in the past with Sqlite was solved by the `RawSqlite` wrapper, which is able to expose the raw connection as well as be compatible with the wrapped `SqlBackend` that it stores. This adds an equivalent wrapper to persistent-postgresql, which exposes the raw connection, and therefore allows third-party libraries to access it.
parsonsmatt
requested changes
Aug 30, 2021
Collaborator
parsonsmatt
left a comment
There was a problem hiding this comment.
Thanks, this looks great!
Let's not introduce microlens dependency and lens generation. I know it was copied from SQLite, but it's not something I'd like to repeat.
ivb-supercede
commented
Aug 31, 2021
ivb-supercede
commented
Aug 31, 2021
This was requested as part of the review on #1305. Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
parsonsmatt
approved these changes
Sep 6, 2021
Collaborator
|
Thanks so much! I'll get this released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #1298.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog