Merged
Conversation
mshima
reviewed
Jan 19, 2025
mshima
approved these changes
Jan 19, 2025
JoshuaKGoldberg
requested changes
Jan 21, 2025
Contributor
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM in general! Just a few suggestions. For me, the discussion on whether to start with automerging is the only one I feel is a blocker for merge.
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
UlisesGascon
added a commit
that referenced
this pull request
Jan 21, 2025
UlisesGascon
added a commit
to yeoman/yo
that referenced
this pull request
Feb 7, 2025
4 tasks
UlisesGascon
added a commit
to yeoman/yeoman-api
that referenced
this pull request
Feb 7, 2025
UlisesGascon
added a commit
to yeoman/yeoman-api
that referenced
this pull request
Feb 7, 2025
UlisesGascon
added a commit
to yeoman/yeoman-test
that referenced
this pull request
Feb 7, 2025
UlisesGascon
added a commit
to yeoman/generator
that referenced
this pull request
Feb 7, 2025
UlisesGascon
added a commit
to yeoman/environment
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first approach, let me know if you prefer different settings I am not opinionated in this case.
Seems like we will need to add renovate to the org in order to make it work.