Fix null-pointer-dereference in yasm_section_bcs_append#263
Merged
PeterJohnson merged 2 commits intoyasm:masterfrom Jun 24, 2024
Merged
Conversation
PeterJohnson
requested changes
Jan 30, 2024
libyasm/section.c
Outdated
| yasm_error_set(YASM_ERROR_VALUE, "Attempt to append bytecode to a NULL section or with a NULL bytecode"); | ||
| return NULL; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Needs indentation fixed to match following code. It's also not possible for bc to be null here, since it's inside of a if (bc) block.
Contributor
Author
There was a problem hiding this comment.
PeterJohnson
approved these changes
Jun 24, 2024
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 29, 2025
yasm is fixed with yasm/yasm#263 AKA yasm/yasm@121ab15 but no stable release with that commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a Null dereference bug in #247