Skip to content

Update deprecated methods for unity 6#47

Closed
lejean wants to merge 2 commits intoyasirkula:masterfrom
lejean:master
Closed

Update deprecated methods for unity 6#47
lejean wants to merge 2 commits intoyasirkula:masterfrom
lejean:master

Conversation

@lejean
Copy link
Copy Markdown

@lejean lejean commented Nov 23, 2025

No description provided.

tigran-sargsyan-w
tigran-sargsyan-w reviewed Nov 26, 2025
View reviewed changes
Copy link
Copy Markdown

@tigran-sargsyan-w tigran-sargsyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a possible review comment you can post:

Hey, nice update 👍

From a quick look, the changes make sense for Unity 6:

  • Swapping the deprecated ShaderUtil calls to shader.GetPropertyCount / GetPropertyType / GetPropertyName looks good and keeps the logic the same.
  • Using the generic TreeView<int> / TreeViewItem<int> API matches the newer UnityEditor IMGUI TreeView API and keeps the rest of the code pretty clean.
  • The ShaderPropertyFlags.NonModifiableTextureData check seems like the right replacement for the old IsShaderPropertyNonModifiableTexureProperty usage.

Only thing I’m wondering about is minimal Unity version support for this repo. If it’s still meant to support older versions, you might want some #if UNITY_... guards around the new APIs. If the plugin is moving fully to the newer versions, then this looks fine as-is.

Overall, this feels like a solid pass over the deprecated APIs 👌

@lejean
Copy link
Copy Markdown
Author

lejean commented Dec 5, 2025

Hey, I added some unity 6 tags

@yasirkula
Copy link
Copy Markdown
Owner

yasirkula commented Dec 6, 2025

Thank you for the PR!

  • Can you revert the latest commit? Your ShaderUtil changes are compatible with minimum supported version (2021 LTS) so there's no need to wrap them inside compiler directives.

  • TreeView<int> related stuff can be reverted to the original version because simply adding the following lines underneath the other using statements will suffice (for SearchResult.cs, only TreeViewItem line is sufficient):

#if UNITY_6000_2_OR_NEWER
using TreeView = UnityEditor.IMGUI.Controls.TreeView<int>;
using TreeViewItem = UnityEditor.IMGUI.Controls.TreeViewItem<int>;
using TreeViewState = UnityEditor.IMGUI.Controls.TreeViewState<int>;
#endif

  • Instead of fully typing UnityEngine.Rendering.ShaderPropertyType, please add a using UnityEngine.Rendering; statement to the top.

  • While replacing ShaderUtil.IsShaderPropertyNonModifiableTexureProperty, use this instead: shader.GetPropertyFlags( i ) & ShaderPropertyFlags.NonModifiableTextureData != 0

@yasirkula
Copy link
Copy Markdown
Owner

yasirkula commented Dec 7, 2025 •
edited
Loading

Actually nevermind because I'll update the codebase to Unity 6.3 and apparently it requires changing those scripts (again), as well. So I'm closing this PR.

@yasirkula yasirkula closed this Dec 7, 2025
yasirkula added a commit that referenced this pull request Dec 31, 2025
@yasirkula
Plugin is now compatible with Unity 6.3 (fixed #46)(fixed #47)
6a158cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tigran-sargsyan-w tigran-sargsyan-w tigran-sargsyan-w left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lejean @yasirkula @tigran-sargsyan-w