fix(pack): sort files to produce identical output on Windows and Unix#8142
Merged
arcanis merged 5 commits intoyarnpkg:masterfrom May 21, 2020
merceyz:pack-issues
Merged
fix(pack): sort files to produce identical output on Windows and Unix#8142arcanis merged 5 commits intoyarnpkg:masterfrom merceyz:pack-issues
arcanis merged 5 commits intoyarnpkg:masterfrom
merceyz:pack-issues
Conversation
arcanis
added a commit
that referenced
this pull request
Aug 27, 2020
…#8142) * fix(pack): always ignore yarnrc.yml file * fix(pack): sort files before packing * docs: changelog * chore: ping ci * Update CHANGELOG.md Co-authored-by: Maël Nison <nison.mael@gmail.com>
This was referenced Mar 15, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
yarn packon Windows and Unix systems produce different results, since on Unix systems the files are sorted while on Windows they aren't.Running
yarn packon https://github.com/arcanis/babel-plugin-lazy-import produces this output on WindowsWhile on Unix it produces
This PR fixes this by telling
tar-fsto sort the files before it packs them.yarn packalso included the.yarnrc.ymlconfig file so I added it to theDEFAULT_IGNORElist.Test plan
Run
yarn packin a repository containing multiple files and check that the output oftar -ztf package.tgzis the same on Windows and Unix