Disable creation of cmdShim PowerShell shims because they don't work and cause problems#6954
Merged
arcanis merged 6 commits intoyarnpkg:masterfrom Mar 14, 2019
Merged
Conversation
This was referenced Jan 24, 2019
|
Can create powershell file, not delete it? |
Member
Contributor
|
This will restore cmd shim creation behaviour to how it was before 1.13. |
Member
|
Sounds good then - I'll merge this and release it with the 1.15.1 |
|
r15ch13
pushed a commit
to ScoopInstaller/Scoop
that referenced
this pull request
Mar 18, 2019
- Yarn's global folder can be set via `yarn config set global-folder` (yarnpkg/yarn#7056) and thus can be persisted. - ~~Since yarn's global bin creating procedure is still problematic (yarnpkg/yarn#6902, **fixed by yarnpkg/yarn#6954 The `.bin` folder in `global\node_modules` is a better path to add to env, and this can avoid the annoying problem when you install scoop in some place except `C:` (that the shims in global bin have wrong relative path pointer). - If you install yarn via `scoop install yarn`, the `Yarn` folder in `$env:LOCALAPPDATA` is useless, and when you uninstall `yarn`, the `.yarnrc` is unused, so the manifest add `uninstaller.script` to remove them when you uninstall. - For reconfiguration, please use `scoop update yarn -f` instead of `scoop reset yarn`. - Close #2969
|
So does this mean I can't use yarn to global install packages? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6902. The latest version of
@zkochan/cmd-shimhas built-in support for PowerShell shims, but they don't work correctly (even the correct .ps1 shims throw errors in PowerShell). In addition, due to the funky way that Yarn handles global binaries, every permutation of (no extension/cmd/ps1) gets created (e.g..cmd.ps1,.cmd.cmd, etc) as a shim. Prior to the update to@zkochan/cmd-shim, Yarn suppressed this by renaming.cmd.cmdto just.cmd, which is not the most elegant solution, but it works. As a (temporary?) workaround to the broken PowerShell shims, this PR simply disables the creation of PowerShell shims altogether whenever Yarn calls@zkochan/cmd-shim.Test plan
A new test was added in
__tests__/commands/global.js(shouldn't create powershell shims) which ensures that no PowerShell shims are created, and that the duplicate-extension files do not exist.