Add inline comments to improve readability of PR #4278#4318
Merged
arcanis merged 2 commits intoyarnpkg:masterfrom Sep 6, 2017
Merged
Add inline comments to improve readability of PR #4278#4318arcanis merged 2 commits intoyarnpkg:masterfrom
arcanis merged 2 commits intoyarnpkg:masterfrom
Conversation
added 2 commits
September 5, 2017 12:28
BYK
approved these changes
Sep 6, 2017
Member
|
I'll leave the final approval and merging to @arcanis since he was the one who reviewed the original PR. |
arcanis
approved these changes
Sep 6, 2017
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…g#4318) * add comments * rewording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses some concerns around readability from PR #4278
Also moved the flagsToOrigin override inside the conditional so that the check is only performed when running from workspace root.
Test plan