fix(core): close stream instead of destroying it#3610
Merged
Conversation
f4ac386 to
95455f2
Compare
arcanis
previously approved these changes
Oct 21, 2021
603c4b7 to
c8cb5fc
Compare
Contributor
|
FWIW this repo could be eligible to Node.js CITGM initiative which would allow to catch this kind of bugs before each new version of Node.js is released. |
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Oct 22, 2021
arcanis
approved these changes
Oct 22, 2021
Contributor
|
@merceyz thanks for the fix! Is a 3.0.3 release planned soon for this bug fix ? |
Member
Author
|
We plan on releasing v3.1 soon™, in the meantime you can use the canary release yarn set version canary |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When parsing tar archives we destroy the
PassThroughstream as soon as thetar.ParseStreamemits thecloseevent but in Node 17 this causes aERR_STREAM_PREMATURE_CLOSEerror.Fixes #3597
How did you fix it?
Call
.endon the stream instead of.destroywhich lets it finish correctly.Checklist