fix(core): ignore yarnrc during prepareExternalProject#1367
Closed
merceyz wants to merge 3 commits into
Closed
Conversation
adb5b6e to
c5368b9
Compare
Member
|
Sounds good to me 👍 While not the problem here, it makes me think: should we also explicitly disable the crlf git translation when cloning the projects? I don't think we currently do it, so it could cause extra deltas. |
Member
Author
|
Sure, I can make a seperate PR to fix that 👍 |
1550c95 to
1c879da
Compare
Merged
Member
Author
|
Fixed upstream in yarnpkg/yarn#8142 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Running
yarn add babel-plugin-lazy-import@arcanis/babel-plugin-lazy-import#589124f8efc62a4f6a38351b9966635ea84ebb29on Windows produces a different checksum than on Unix machines.The reason for this is that when Yarn downloads the Yarn 1 cli it creates a
.yarnrc.ymlfile with\r\nline endings on Windows and\non Unix which is included when packing with Yarn 1.How did you fix it?
Ignore
.yarnrc.ymlwhen packing with Yarn 1.