fix(deno): specify deps (avoids Deno warnings) by rivy · Pull Request #464 · yargs/yargs-parser

rivy · 2022-10-09T19:56:48Z

The current version causes Deno to report warnings when imported.
This PR pins the version to the current Deno std (0.159.0) and removes the warnings.

$ deno run -r deno.ts
Warning Implicitly using latest version (0.159.0) for https://deno.land/std/path/mod.ts

$ git checkout fix.deno
Previous HEAD position was 3aba24c chore(main): release yargs-parser 21.1.1 (#455)
Switched to a new branch 'fix.deno'
Branch 'fix.deno' set up to track remote branch 'fix.deno' from 'origin'.

$ deno run -r deno.ts

rivy · 2022-10-29T14:57:00Z

@bcoe, review?

bcoe · 2022-11-03T18:40:13Z

Change looks good to me, but we seem to have a regression with the rollup dependency :/

rivy · 2022-11-04T06:29:33Z

I added a commit updating rollup and associated modules. It includes a necessary change from rollup-plugin-ts to @rollup/plugin-typescript.

It builds/tests successfully for me, locally and the CI workflow, with NodeJS v12+.

rivy · 2022-11-04T14:05:58Z

I revised the build changes to a minimal set that works with NodeJS v12+ and mirrored the changes to the yargs/y18n PR.
There are some notsup complaints, specifically for NodeJS v12, but everything builds and tests correctly.
If your CI passes then this should be complete.

Note, though these PR changes shouldn't have changed any coverage metrics, I am getting a coverage threshold error...

------------------------|---------|----------|---------|---------|-------------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s       
------------------------|---------|----------|---------|---------|-------------------------
All files               |   99.42 |    97.82 |     100 |   99.42 |                         
 index.ts               |    88.7 |    61.53 |     100 |    88.7 | 43-49                   
 string-utils.ts        |     100 |      100 |     100 |     100 |                         
 tokenize-arg-string.ts |     100 |      100 |     100 |     100 |                         
 yargs-parser-types.ts  |     100 |      100 |     100 |     100 |                         
 yargs-parser.ts        |     100 |    98.64 |     100 |     100 | 159,633,727-729,744,953 
------------------------|---------|----------|---------|---------|-------------------------
ERROR: Coverage for lines (99.42%) does not meet global threshold (99.5%)
ERROR: Coverage for statements (99.42%) does not meet global threshold (99.5%)

... if you want to add a test.

rivy · 2022-11-23T04:27:45Z

@bcoe , as the changes here in the PR didn't actually change any of the coverage tested files, how about just changing the thresholds for line and statement %'s to "99"?

Or, maybe better, use /* c8 ignore start */ ... /* c8 ignore stop */ directives around the lines 43-49 within index.ts since they're not testable with CJS.

rivy · 2022-11-23T05:04:16Z

@bcoe , CI now passes with the added /* c8 ignore start */ ... /* c8 ignore stop */ directives.

rivy · 2022-12-07T14:53:49Z

@bcoe , review?

rivy · 2022-12-12T00:28:43Z

@bcoe , once this is merged, it and yargs/y18n#147 can be used within yargs, which should fix all Deno warnings (excepting the escalade lack of explicit versioning, ref: lukeed/escalade#8 and yargs/yargs#2217 (comment)).

When done, I'll close yargs ~ PR #2216 and just fork and publish a yargs version for Deno with a fix for the escalade problem.

rivy · 2023-01-01T20:42:40Z

@bcoe , just checking back in... I believe all CI should PASS.

rivy · 2023-01-21T04:18:22Z

Ping @bcoe.

shadowspawn · 2023-04-16T06:15:09Z

I have not reviewed this PR but noticed the dependency updates. Just noting I have added a couple of other PRs with approaches to updating dependencies: #478 and #471

rivy · 2023-11-20T03:11:52Z

☠️ ⚰️
It's been a year; I'll move on with a fork containing the needed fixes.

- best practice and strongly needed b/c Deno does *not* use semantic versioning - avoids Deno warnings - also avoids Deno prompts # refs - [fix(deno): specify deps (avoids Deno warnings)](yargs#464) - closed for non-participation at 1 yr open - [fix(deno): refactor to avoid prompts during module import](yargs/yargs#2217 (comment)) ## related discussion/issues [refactor ~ implement *no-panic*/*no-prompt* changes](rivy/deno.dxx@a53375d) @@ <https://archive.is/Esp5e> [fix(node): Make global.ts evaluate synchronously](denoland/std#2098) [Execution order of imports in deno is unclear/unexpected](denoland/deno#14243) [std/node should avoid TLA](denoland/std#2097) [HowTO test that a module is *no-panic* and *no-prompt* when statically imported?](denoland/deno/issues/#15356) [Discussion ~ Bring back permission prompt behind a flag](denoland/deno/issues/#3811) [Security prompt by default (instead of throw)](denoland/deno/issues/#10183) [Seeking a better UX for permissions](denoland/deno/issues/#11061) [Design Meeting 2021-07-29 ~ `Prompt by default`](denoland/deno/issues/#11767) [permission prompt problems](denoland/deno/issues/#11936) [`deno repl` has permissions by default?](denoland/deno/issues/#12665) [Bad UX with prompt by default](denoland/deno/issues/#13730) [DENO_NO_PROMPT env var support](denoland/deno/issues/#14208) [feat: Add DENO_NO_PROMPT variable](denoland/deno/issues/#14209)

rivy mentioned this pull request Oct 9, 2022

fix(deno): refactor to avoid prompts during module import (#2216) yargs/yargs#2217

Merged

rivy force-pushed the fix.deno branch from 9cec724 to dafd36d Compare November 4, 2022 06:16

rivy force-pushed the fix.deno branch from dafd36d to 856ace3 Compare November 4, 2022 13:49

rivy added 2 commits November 4, 2022 08:54

fix(build): fix build failures with updated rollup TS plugin

61b6eae

fix(deno): specify deps (avoids Deno warnings)

236f06c

rivy force-pushed the fix.deno branch 2 times, most recently from 3007efc to 236f06c Compare November 4, 2022 13:57

bcoe approved these changes Nov 11, 2022

View reviewed changes

bcoe added the ci label Nov 11, 2022

fix(build): ignore problematic uncovered lines (due to CJS vs ESM logic)

31880da

rivy closed this Nov 20, 2023

rivy deleted the fix.deno branch November 20, 2023 03:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deno): specify deps (avoids Deno warnings)#464

fix(deno): specify deps (avoids Deno warnings)#464
rivy wants to merge 3 commits intoyargs:mainfrom
rivy-fix:fix.deno

rivy commented Oct 9, 2022

Uh oh!

rivy commented Oct 29, 2022

Uh oh!

bcoe commented Nov 3, 2022

Uh oh!

rivy commented Nov 4, 2022

Uh oh!

rivy commented Nov 4, 2022 •

edited

Loading

Uh oh!

rivy commented Nov 23, 2022 •

edited

Loading

Uh oh!

rivy commented Nov 23, 2022

Uh oh!

rivy commented Dec 7, 2022

Uh oh!

rivy commented Dec 12, 2022 •

edited

Loading

Uh oh!

rivy commented Jan 1, 2023

Uh oh!

rivy commented Jan 21, 2023

Uh oh!

shadowspawn commented Apr 16, 2023

Uh oh!

rivy commented Nov 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rivy commented Oct 9, 2022

Uh oh!

rivy commented Oct 29, 2022

Uh oh!

bcoe commented Nov 3, 2022

Uh oh!

rivy commented Nov 4, 2022

Uh oh!

rivy commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rivy commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rivy commented Nov 23, 2022

Uh oh!

rivy commented Dec 7, 2022

Uh oh!

rivy commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rivy commented Jan 1, 2023

Uh oh!

rivy commented Jan 21, 2023

Uh oh!

shadowspawn commented Apr 16, 2023

Uh oh!

rivy commented Nov 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rivy commented Nov 4, 2022 •

edited

Loading

rivy commented Nov 23, 2022 •

edited

Loading

rivy commented Dec 12, 2022 •

edited

Loading