Skip to content

feat: adds support for async builder#1888

Merged
bcoe merged 7 commits intomasterfrom
async-builder
Mar 26, 2021
Merged

feat: adds support for async builder#1888
bcoe merged 7 commits intomasterfrom
async-builder

Conversation

@bcoe
Copy link
Copy Markdown
Member

@bcoe bcoe commented Mar 14, 2021 •
edited
Loading

Fixes: #1042
BREAKING CHANGE: providing an async builder will now cause yargs to return async result
BREAKING CHANGE: .positional() now allowed at root level of yargs.

@bcoe bcoe mentioned this pull request Mar 26, 2021
Closed
@bcoe bcoe merged commit ade29b8 into master Mar 26, 2021
@bcoe bcoe deleted the async-builder branch March 26, 2021 22:34
@bcoe bcoe mentioned this pull request Apr 3, 2021
Merged
bcoe pushed a commit that referenced this pull request Apr 3, 2021
fix(async): don't call parse callback until async ops complete (#1896)
a93f5ff 
If a callback is provided to parse() it will now be executed after all promises have resolved.

The cause of #1888, was that this[kUnfreeze](); was being called too soon, which set this.#parseFn to null.

Fixes #1888
This was referenced Nov 25, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow command builder to accept a promise

1 participant

@bcoe