Allow to turn off sorting keys in Dumper (2)#254
Allow to turn off sorting keys in Dumper (2)#254perlpunk wants to merge 1 commit intoyaml:masterfrom
Conversation
ingydotnet
left a comment
There was a problem hiding this comment.
Looks good. Let's merge this into release/5.1 branch and remove the old sort commit.
|
No, the old commit in release/5.1 is ok and the same as in this PR. I just wanted to avoid that the commit gets lost. The old PR has a problem in the tests, and I fixed it only in the release branch release/4.3, and you took my commits from release/4.3 and put them squashed into release/5.1. To make it more transparent, I created a PR. |
|
Is this already in 5.1 then? |
|
I fixed my ordering issue simply by kludging representer.py line 111 (eleventy-one :)) to be a NOOP, i.e. Excuse the facetious comment: it's just one line change, what could break...? |
|
@ofek yes, it's planned to be in 5.1 |
|
merged in 07c88c6 |
…_keys arg. As far as I can tell, no other changes cause problems. (While I'm here, go ahead and rely on the new default default_flow_style=False.) Fixes #40.
* sklearn 1.0+ requires Python 3.7+ * sklearn's minimum numpy dependency is 1.14.6 * PyYAML 5.1 introduced several backward-incompatile changes that we already adapted, including: - yaml/pyyaml#254 - yaml/pyyaml#256
This is a followup to #143, based on current master (and with tests
fixed like on the release branches)