Open
Conversation
Contributor
|
@ingydotnet this looks fine to me, do you have opinions? Also, do you know why Travis isn't running against these PRs? |
Author
|
sorry, I forgot ignore the white space at first. so I update the PR . |
Author
|
I found another bug. This is a valid yaml document, but libyaml report found unexpected ':' 1:0 is a sexagesimal . See http://yaml.org/spec/1.1/ Example 2.19. Integers |
Member
|
I'd like to see tests added for these things. We might want to split this into 2 PRs. URLs are probably a more common reason for ':' in plain scalar, than Failing tests: Unicode anchors: Colon in flow plain: |
Author
|
I remove the last commit just now , and would make a new pr for ':' in plain scalar. |
cloudwu
added a commit
to cloudwu/libyaml
that referenced
this pull request
Dec 3, 2016
cloudwu
added a commit
to cloudwu/libyaml
that referenced
this pull request
Dec 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For yaml 1.1 sepc, anchor name can be any unicode char (http://yaml.org/spec/1.1/#id899912)