Skip to content

Adding parameters to copied annotations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yDelouis merged 1 commit into from
May 2, 2014
Merged

Adding parameters to copied annotations #1

yDelouis merged 1 commit into from
May 2, 2014

Conversation

@WonderCsabo
Copy link

@WonderCsabo WonderCsabo commented May 1, 2014

No description provided.

@WonderCsabo
Adding parameters to copied annotations
5b31f20 
We are copying all annotations to overriden classes, methods, method
arguments etc, what are not from our package. This commit adds the
ability to AA to copy the annotation parameters, too.
Note that annotation as an annotation parameter is not supported yet.
@WonderCsabo WonderCsabo mentioned this pull request May 1, 2014
Merged
yDelouis added a commit that referenced this pull request May 2, 2014
@yDelouis
Merge pull request #1 from WonderCsabo/782_otherAnnotations
41e1ae0 
Adding parameters to copied annotations
@yDelouis yDelouis merged commit 41e1ae0 into yDelouis:782_otherAnnotations May 2, 2014
@yDelouis
Copy link
Owner

yDelouis commented May 2, 2014

👍 Great job ! Thanks

@WonderCsabo
Copy link
Author

WonderCsabo commented May 2, 2014

I forgot to add license headers. Please merge the last commit from WonderCsabo:782_otherAnnotations.

@yDelouis
Copy link
Owner

yDelouis commented May 2, 2014

Done.

@WonderCsabo
Copy link
Author

WonderCsabo commented May 2, 2014

Do you have any idea about annotation parameters?

@yDelouis
Copy link
Owner

yDelouis commented May 2, 2014

I tried using Class.forName, but it doesn't work if the annotation is defined in the same project because the .class file doesn't exist yet during annotations processing. (It seems to work if the annotation come from a dependency).

I succeed to make it work with annotation parameters using reflection to access the private constructor of JAnnotationUse(JClass clazz) and the private method addValue(String name, JAnnotationValue value). But it smells very bad.

@WonderCsabo
Copy link
Author

WonderCsabo commented May 2, 2014

Smells bad or not,unfortunately i see no way other than Reflection.

@yDelouis
Copy link
Owner

yDelouis commented May 2, 2014

I have pushed my changes on my PR to the excilys repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WonderCsabo @yDelouis