Skip to content

feat(new-webui): Add more options to time range presets.#990

Merged
davemarco merged 2 commits into
y-scope:mainfrom
davemarco:options
Jun 10, 2025
Merged

feat(new-webui): Add more options to time range presets.#990
davemarco merged 2 commits into
y-scope:mainfrom
davemarco:options

Conversation

@davemarco

@davemarco davemarco commented Jun 9, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

PR adds two more options to time range presets. Originally, I didn't really think too much about presets. Still less than old webui (i think less is more), but adds a couple new ones.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Summary by CodeRabbit

  • New Features
    • Added new time range options: "Last 12 Months" and "Year to Date" for time-based searches.

@davemarco davemarco requested a review from a team as a code owner June 9, 2025 19:26
@coderabbitai

coderabbitai Bot commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Two new time range options, "Last 12 Months" and "Year to Date," were added to the time range selection logic. These options are now available in the relevant enum and are mapped to their corresponding date ranges in the configuration.

Changes

File Change Summary
.../SearchPage/SearchControls/TimeRangeInput/utils.tsx Added "Last 12 Months" and "Year to Date" to time range enum and mapping configuration.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant TimeRangeUtils

    User->>UI: Selects time range option
    UI->>TimeRangeUtils: Requests date range for selected option
    TimeRangeUtils-->>UI: Returns date range (including new "Last 12 Months" or "Year to Date")
    UI-->>User: Displays results for selected time range
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f1b0dc and c2bfe7c.

📒 Files selected for processing (1)
  • components/log-viewer-webui/client/src/pages/SearchPage/SearchControls/TimeRangeInput/utils.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}`: - Prefer `false == ` rather than `!`.

**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}: - Prefer false == <expression> rather than !<expression>.

  • components/log-viewer-webui/client/src/pages/SearchPage/SearchControls/TimeRangeInput/utils.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: conventional-commits
🔇 Additional comments (4)
components/log-viewer-webui/client/src/pages/SearchPage/SearchControls/TimeRangeInput/utils.tsx (4)

14-14: Add LAST_12_MONTHS to the time‐range enum
This new entry is correctly positioned after LAST_30_DAYS and follows the existing naming and string‐literal patterns.

16-16: Include YEAR_TO_DATE in the time‐range enum
The entry is placed immediately after MONTH_TO_DATE, matching the intended logical ordering.

37-38: Map LAST_12_MONTHS to the correct Dayjs interval
The range from 12 months ago to now aligns with expectations and uses the established subtract(12, "month") pattern.

41-42: Map YEAR_TO_DATE to start‐of‐year through now
Using startOf("year") to dayjs() cleanly captures the year‐to‐date range as intended.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@davemarco davemarco requested a review from junhaoliao June 9, 2025 19:26
@davemarco davemarco changed the title fix(new-webui): Add more options to time range presets. feat(new-webui): Add more options to time range presets. Jun 9, 2025
@davemarco davemarco merged commit d333324 into y-scope:main Jun 10, 2025
7 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jun 11, 2025
Merged
3 tasks
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@davemarco
feat(new-webui): Add more options to time range presets. (y-scope#990)
dfa1b74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davemarco @junhaoliao