Skip to content

feat(new-webui): Display sizes using binary units (resolves #947).#959

Merged
davemarco merged 2 commits into
y-scope:mainfrom
davemarco:kib
Jun 4, 2025
Merged

feat(new-webui): Display sizes using binary units (resolves #947).#959
davemarco merged 2 commits into
y-scope:mainfrom
davemarco:kib

Conversation

@davemarco

@davemarco davemarco commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note this should be merged before #958

Description

move to binary units
Resolves #947.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Now in binary units

Summary by CodeRabbit

  • Style
    • Updated formatting of size and speed values for improved consistency in display.

@davemarco davemarco requested a review from a team as a code owner June 3, 2025 19:53
@coderabbitai

coderabbitai Bot commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The code change updates the convertQueryJobsItemToJobData function to explicitly pass false as the second argument to the formatSizeInBytes function, ensuring that sizes are formatted using binary units instead of SI units. No other logic or function signatures are modified.

Changes

File(s) Change Summary
components/log-viewer-webui/client/src/pages/IngestPage/Jobs/utils.ts Updated calls to formatSizeInBytes to pass false for binary unit display

Assessment against linked issues

Objective Addressed Explanation
Display sizes using binary units by setting useSiUnits to false (#947) ✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98acf70 and 0cfd611.

📒 Files selected for processing (1)
  • components/log-viewer-webui/client/src/pages/IngestPage/Jobs/utils.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}`: - Prefer `false == ` rather than `!`.

**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}: - Prefer false == <expression> rather than !<expression>.

  • components/log-viewer-webui/client/src/pages/IngestPage/Jobs/utils.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint-check (ubuntu-latest)
  • GitHub Check: lint-check (macos-latest)
🔇 Additional comments (3)
components/log-viewer-webui/client/src/pages/IngestPage/Jobs/utils.ts (3)

59-59: Consistent binary unit formatting applied.

The change correctly applies binary unit formatting to compressed size values, maintaining consistency with the uncompressed size formatting.

67-67: Binary unit formatting correctly applied to speed calculation.

The change appropriately applies binary unit formatting to the speed calculation, ensuring all size-related values in the job data use consistent binary units for display.

54-54:

Details

✅ Verification successful

Verify the formatSizeInBytes parameter usage for binary units.

The addition of false as the second parameter appears to enable binary unit formatting. Please confirm that this parameter correctly enables binary units and that all calls to formatSizeInBytes throughout the codebase have been consistently updated.

🏁 Script executed:

#!/bin/bash
# Description: Verify formatSizeInBytes function signature and find all its usages to ensure consistency.

# Find the formatSizeInBytes function definition to understand the second parameter
echo "=== formatSizeInBytes function definition ==="
ast-grep --pattern 'function formatSizeInBytes($_, $_) { $$$ }'
ast-grep --pattern 'const formatSizeInBytes = ($_, $_) => { $$$ }'
ast-grep --pattern 'export function formatSizeInBytes($_, $_) { $$$ }'

# Find all calls to formatSizeInBytes to ensure consistency
echo -e "\n=== All formatSizeInBytes function calls ==="
rg -A 2 -B 1 'formatSizeInBytes\(' --type ts --type tsx --type js --type jsx

Length of output: 520

I’m not finding any definitions or usages of formatSizeInBytes with the previous patterns. Let’s do a global search to locate its declaration and all call sites:

🏁 Script executed:

#!/bin/bash
# Search for both the function declaration/assignment and all invocations
echo "=== formatSizeInBytes occurrences ==="
rg -n 'formatSizeInBytes' .

Length of output: 892

Binary-unit flag correctly applied

Verified that formatSizeInBytes in
components/log-viewer-webui/client/src/pages/IngestPage/Jobs/units.ts
accepts a useSI boolean (default true), so passing false indeed switches to binary units. A project-wide search shows all three invocations in utils.ts have been updated, with no other calls remaining.

No further action needed.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@davemarco davemarco requested a review from junhaoliao June 3, 2025 19:53
@davemarco davemarco merged commit 6c51bde into y-scope:main Jun 4, 2025
6 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jun 9, 2025
Merged
3 tasks
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@davemarco
feat(new-webui): Display sizes using binary units (resolves y-scope#947…
2efd714 
…). (y-scope#959)

Co-authored-by: Marco <david.marcovitch@yscope.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

@junhaoliao junhaoliao Awaiting requested review from junhaoliao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[new-webui] Display sizes using binary units.

2 participants

@davemarco @kirkrodrigues