Skip to content

feat(new-webui): Redirect root path to ingest page.#936

Merged
junhaoliao merged 2 commits into
y-scope:mainfrom
junhaoliao:router-default-page
May 29, 2025
Merged

feat(new-webui): Redirect root path to ingest page.#936
junhaoliao merged 2 commits into
y-scope:mainfrom
junhaoliao:router-default-page

Conversation

@junhaoliao

@junhaoliao junhaoliao commented May 28, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Redirect root path to "/ingest" in routes configuration

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  1. Loaded http://localhost:8080 -> auto redirect to http://localhost:8080/ingest

Summary by CodeRabbit

  • New Features
    • Users visiting the root path ("/") are now automatically redirected to the "/ingest" page for a smoother navigation experience.

@junhaoliao junhaoliao requested a review from a team as a code owner May 28, 2025 20:48
@junhaoliao junhaoliao requested a review from davemarco May 28, 2025 20:48
@coderabbitai

coderabbitai Bot commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The router configuration in the web UI was updated to add a redirect from the root path ("/") to "/ingest" using the Navigate component. The import statement was adjusted to include Navigate. No other routes or components were modified, and the router export remains unchanged.

Changes

File(s) Change Summary
components/log-viewer-webui/client/src/router.tsx Added a redirect route at "/" to "/ingest" using Navigate; updated imports to include Navigate.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Router
    participant IngestPage

    User->>Router: Accesses "/"
    Router-->>User: Redirects to "/ingest" (with replace)
    User->>Router: Accesses "/ingest"
    Router-->>IngestPage: Renders IngestPage
Loading

Possibly related PRs

Suggested reviewers

  • hoophalab
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e864329 and 1d7210d.

📒 Files selected for processing (1)
  • components/log-viewer-webui/client/src/router.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}`: - Prefer `false == ` rather than `!`.

**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}: - Prefer false == <expression> rather than !<expression>.

  • components/log-viewer-webui/client/src/router.tsx
🧠 Learnings (1)
components/log-viewer-webui/client/src/router.tsx (2) 
Learnt from: davemarco
PR: y-scope/clp#797
File: components/log-viewer-webui/client/src/routes/routes.tsx:1-1
Timestamp: 2025-04-04T15:15:59.432Z
Learning: In React Router v7, `createBrowserRouter` and other router primitives should be imported from `react-router` package, not from `react-router-dom` as in previous versions. This represents a significant change in the library's structure where router primitives are now in the core package.

Learnt from: davemarco
PR: y-scope/clp#797
File: components/log-viewer-webui/client/src/components/Layout/MainLayout.tsx:2-5
Timestamp: 2025-04-08T22:32:05.366Z
Learning: In this codebase using React Router v7.4.1, components should be imported directly from "react-router" (e.g., `import { Link, Outlet } from "react-router";`) rather than from "react-router-dom" as was common in previous versions of React Router.
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint-check (macos-latest)
  • GitHub Check: lint-check (ubuntu-latest)
🔇 Additional comments (2)
components/log-viewer-webui/client/src/router.tsx (2)

1-4: LGTM! Correct import for React Router v7.

The import statement correctly includes the Navigate component from "react-router", which aligns with React Router v7 conventions as noted in the retrieved learnings.

16-21: LGTM! Well-implemented redirect route.

The redirect implementation is correct and follows best practices:

  • The route structure properly nests the redirect under the main layout
  • Using replace={true} prevents polluting the browser history stack
  • The redirect target "/ingest" matches the existing route structure
  • The JSX formatting and indentation are consistent with the rest of the file

This change successfully achieves the PR objective of redirecting users from the root path to the ingest page.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

davemarco
davemarco approved these changes May 29, 2025
View reviewed changes

@davemarco davemarco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm:

title: feat(new-webui): Redirect root path to ingest page.

@junhaoliao junhaoliao changed the title feat(new-webui): Redirect root path to "/ingest" in routes configuration. feat(new-webui): Redirect root path to ingest page. May 29, 2025
@junhaoliao junhaoliao merged commit 3cdf1ec into y-scope:main May 29, 2025
6 checks passed
@junhaoliao junhaoliao deleted the router-default-page branch May 29, 2025 17:17
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@junhaoliao
feat(new-webui): Redirect root path to ingest page. (y-scope#936)
17827b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davemarco davemarco davemarco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junhaoliao @davemarco