Skip to content

fix(new-webui): Configure Vite base parameter to allow hosting in subdirectories (fixes #867).#875

Merged
AVMatthews merged 3 commits into
y-scope:mainfrom
AVMatthews:smallFixes
May 2, 2025
Merged

fix(new-webui): Configure Vite base parameter to allow hosting in subdirectories (fixes #867).#875
AVMatthews merged 3 commits into
y-scope:mainfrom
AVMatthews:smallFixes

Conversation

@AVMatthews

@AVMatthews AVMatthews commented May 1, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes issue #867.

Adds base to the client Vite config.

Checklist

  • [ x] The PR satisfies the contribution guidelines.
  • [x ] This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • [x ] Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Verified that the individual resources from the index.html in the list directory.

Started the webui, compressed and searched a file, and verified that the links froth search results directed correctly to the log viewer.

Summary by CodeRabbit

  • Chores
    • Updated asset paths to be relative to the current directory for improved compatibility when deploying built files.

@AVMatthews AVMatthews requested a review from a team as a code owner May 1, 2025 20:09
@coderabbitai

coderabbitai Bot commented May 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The Vite configuration file for the log viewer web UI client was updated to include a base property set to "./". This change ensures that the built asset URLs are relative to the current directory. Additionally, the publicDir property was repositioned within the configuration object without any change to its value. No other configuration options or logic were modified in this update.

Changes

File(s) Change Summary
components/log-viewer-webui/client/vite.config.ts Added base: "./" to the exported Vite configuration object; repositioned publicDir: "public" within the object.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ea43b4 and 5724f6b.

📒 Files selected for processing (1)
  • components/log-viewer-webui/client/vite.config.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • components/log-viewer-webui/client/vite.config.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint-check (ubuntu-latest)
  • GitHub Check: lint-check (macos-latest)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

junhaoliao
junhaoliao reviewed May 1, 2025
View reviewed changes
Comment thread components/log-viewer-webui/client/vite.config.ts Outdated
@junhaoliao

junhaoliao commented May 1, 2025

Copy link
Copy Markdown
Member

For the PR title, how about

fix(new-webui): Configure Vite `base` parameter to allow hosting in subdirectories (fixes #867).

@AVMatthews AVMatthews changed the title fix(log-viewer-webui): Add base to client Vite (fixes #867). fix(new-webui): Configure Vite base parameter to allow hosting in subdirectories (fixes #867). May 1, 2025
@AVMatthews AVMatthews requested a review from junhaoliao May 1, 2025 21:20
@AVMatthews AVMatthews merged commit 71f1b38 into y-scope:main May 2, 2025
5 checks passed
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@AVMatthews
fix(new-webui): Configure Vite base parameter to allow hosting in s…
937cabb 
…ubdirectories (fixes y-scope#867). (y-scope#875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

Assignees

@junhaoliao junhaoliao

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AVMatthews @junhaoliao