Skip to content

build: Update to the latest version of yscope-dev-utils.#874

Merged
LinZhihao-723 merged 2 commits into
y-scope:mainfrom
LinZhihao-723:dev-utils-update
May 1, 2025
Merged

build: Update to the latest version of yscope-dev-utils.#874
LinZhihao-723 merged 2 commits into
y-scope:mainfrom
LinZhihao-723:dev-utils-update

Conversation

@LinZhihao-723

@LinZhihao-723 LinZhihao-723 commented May 1, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

y-scope/yscope-dev-utils#44 updates clang-tidy config to ignore code inside macros for function cognitive complexity check. This PR updates yscope-dev-utils to the latest commit to pull this clang-tidy config update.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Ensure all workflows passed.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to the latest version.

@LinZhihao-723 LinZhihao-723 requested a review from a team as a code owner May 1, 2025 00:19
@coderabbitai

coderabbitai Bot commented May 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

"""

Walkthrough

The pull request updates the tools/yscope-dev-utils subproject by changing its commit reference from e300d1bab4c2f33cbf9ddf9f0c08185faf035070 to 56740d33164f80c00daef37542a27dffcef3a7e1. Additionally, the tools/scripts/deps-download/init.sh script was modified to download the updated yscope-dev-utils version by changing the commit hash in the download URL and the expected extraction directory name. No other code or functionality changes were made, and there are no alterations to exported or public entities.

Changes

File(s) Change Summary
tools/yscope-dev-utils (subproject ref) Updated commit reference from e300d1bab4c2f33cbf9ddf9f0c08185faf035070 to 56740d33164f80c00daef37542a27dffcef3a7e1
tools/scripts/deps-download/init.sh Updated download URL and extraction directory name to match new yscope-dev-utils commit hash

Possibly related PRs

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 15735b6 and c7744e0.

📒 Files selected for processing (1)
  • tools/scripts/deps-download/init.sh (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • tools/scripts/deps-download/init.sh
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: ubuntu-jammy-lint
  • GitHub Check: centos-stream-9-static-linked-bins
  • GitHub Check: centos-stream-9-dynamic-linked-bins
  • GitHub Check: ubuntu-jammy-static-linked-bins
  • GitHub Check: ubuntu-jammy-dynamic-linked-bins
  • GitHub Check: build-macos (macos-15, false)
  • GitHub Check: build-macos (macos-15, true)
  • GitHub Check: build-macos (macos-14, true)
  • GitHub Check: build-macos (macos-13, false)
  • GitHub Check: lint-check (macos-latest)
  • GitHub Check: lint-check (ubuntu-latest)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

kirkrodrigues
kirkrodrigues requested changes May 1, 2025
View reviewed changes

@kirkrodrigues kirkrodrigues left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update tools/scripts/deps-download/init.sh.

@LinZhihao-723

LinZhihao-723 commented May 1, 2025

Copy link
Copy Markdown
Member Author

We also need to update tools/scripts/deps-download/init.sh.

Mb. Fixed.

kirkrodrigues
kirkrodrigues approved these changes May 1, 2025
View reviewed changes

@kirkrodrigues kirkrodrigues left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, can we drop the "taskfiles" scope? The reason the previous update had that scope is because the PR also changed the path of the taskfiles.

@LinZhihao-723 LinZhihao-723 changed the title build(taskfiles): Update to the latest version of yscope-dev-utils. build: Update to the latest version of yscope-dev-utils. May 1, 2025
@LinZhihao-723 LinZhihao-723 merged commit 5ff5995 into y-scope:main May 1, 2025
22 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 25, 2025
Merged
4 tasks
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@LinZhihao-723
build: Update to the latest version of yscope-dev-utils. (y-scope#874)
32539a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LinZhihao-723 @kirkrodrigues