fix(lint): Lock eslint-config-yscope at 0.0.32 to avoid lint failures caused by newer versions.#661
Merged
Merged
Conversation
Contributor
WalkthroughThe pull request introduces several changes across different components of a web application. These modifications primarily focus on dependency management, linting processes, and version control configurations. The changes involve updating npm installation methods to use Changes
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant NPM as npm
participant Linter as Project Linter
Dev->>NPM: npm clean-install
NPM-->>Dev: Clean dependency installation
Dev->>Linter: Run lint:check
Linter-->>Dev: Linting results
Dev->>Linter: Apply --fix
Linter-->>Dev: Fixed code
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
eslint-config-yscope at 0.0.32 to fix lint failures.eslint-config-yscope at 0.0.32 to fix lint failures caused by a newer version of eslint-config-yscope.
eslint-config-yscope at 0.0.32 to fix lint failures caused by a newer version of eslint-config-yscope.eslint-config-yscope at 0.0.32 to avoid lint failures caused by newer versions.
| "client:lint:fix": "cd client && npm run lint:fix", | ||
| "client:start": "cd client && npm start", | ||
| "init": "npm i && (cd client && npm i) && (cd server && npm i)", | ||
| "init": "npm ci && (cd client && npm ci) && (cd server && npm ci)", |
Member
There was a problem hiding this comment.
Not mandatory, but to follow our conventions, shall we use the long-form command name (clean-install)?
| - |- | ||
| cd "{{.OUTPUT_DIR}}/var/www/log_viewer_webui/server" | ||
| PATH="{{.G_NODEJS_22_BIN_DIR}}":$PATH npm clean-install | ||
| PATH="{{.G_NODEJS_22_BIN_DIR}}":$PATH npm install |
Member
Author
There was a problem hiding this comment.
Sorry, i meant not to make everything "clean-install" in this PR since not all are directly related to lint, but reverted the wrong line.
kirkrodrigues
approved these changes
Jan 13, 2025
3 tasks
3 tasks
This was referenced Mar 7, 2025
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…es caused by newer versions. (y-scope#661)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
eslint-config-yscopeat 0.0.32 to fix lint failurescomponents/log-viewer-webui/client/package-lock.jsoncomponents/log-viewer-webui/server/package-lock.jsoncomponents/webui/linter/package.jsoncomponents/webui/linter/package-lock.jsonand add the file to VCS.sourceslist in tasklinter-node-modules.Validation performed
task lint:checkand observed no failure.components/webui/client/main.jsx, rantask lint:checkand observed errortask lint:fixand observed no failure.task lint:checkand and observed no failure.Summary by CodeRabbit
Release Notes
Chores
npm clean-installfor more consistent package management.gitignoreto trackpackage-lock.jsonfor the linterDependency Updates
eslint-config-yscopeto version 0.0.32These changes improve project dependency management and linting consistency across the development environment.