Change ErrorCode enum to an enum class#55
Closed
SharafMohamed wants to merge 1 commit into
Closed
Conversation
kirkrodrigues
requested changes
Mar 6, 2022
| Failure_DB_Bulk_Write, | ||
| }; | ||
|
|
||
| /* |
Member
There was a problem hiding this comment.
Can delete the commented enum.
Member
|
Closing due to the age of the PR (too many conflicts which would require a lot of refactoring) and because it's not critical functionality. |
Bill-hbrhbr
added a commit
to Bill-hbrhbr/clp
that referenced
this pull request
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Changed ErrorCode enum to an enum class in ErrorCode.hpp
Validation performed
Validated that compression and decompression operated as normal