Add initial implementation of regex_utils library containing a regex to wildcard string translator and a corresponding std::error_code enum and category.#482
Merged
Bill-hbrhbr merged 11 commits intoy-scope:mainfrom Jul 19, 2024
Conversation
davidlion
requested changes
Jul 17, 2024
components/core/src/clp/regex_utils/regex_translation_utils.cpp
Outdated
Show resolved
Hide resolved
components/core/src/clp/regex_utils/regex_translation_utils.cpp
Outdated
Show resolved
Hide resolved
components/core/src/clp/regex_utils/regex_translation_utils.cpp
Outdated
Show resolved
Hide resolved
components/core/src/clp/regex_utils/regex_translation_utils.cpp
Outdated
Show resolved
Hide resolved
components/core/src/clp/regex_utils/regex_translation_utils.hpp
Outdated
Show resolved
Hide resolved
LinZhihao-723
requested changes
Jul 18, 2024
components/core/src/clp/regex_utils/regex_translation_utils.cpp
Outdated
Show resolved
Hide resolved
components/core/src/clp/regex_utils/regex_translation_utils.cpp
Outdated
Show resolved
Hide resolved
0ca0260 to
876e9f9
Compare
davidlion
reviewed
Jul 19, 2024
components/core/src/clp/regex_utils/regex_translation_utils.cpp
Outdated
Show resolved
Hide resolved
davidlion
previously approved these changes
Jul 19, 2024
Member
davidlion
left a comment
There was a problem hiding this comment.
Add an initial implementation of the regex_utils library, containing a regex to wildcard string translator and a corresponding std::error_code enum and category.
LinZhihao-723
requested changes
Jul 19, 2024
Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com>
LinZhihao-723
previously approved these changes
Jul 19, 2024
davidlion
approved these changes
Jul 19, 2024
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
…to wildcard string translator and a corresponding std::error_code enum and category. (y-scope#482) Co-authored-by: Bingran Hu <bingran.hu@yscope.com> Co-authored-by: davidlion <david.lion@yscope.com> Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com> Co-authored-by: Kirk Rodrigues <2454684+kirkrodrigues@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For wildcard queries that are disguised as regex queries, perform a best-effort translation so that CLP can turn such queries into more efficient searches.
Current translation functionalities include:
.into?.*into*.+into?*A
std::error_codewrapper has been implemented for failed translations so that the translation functions haveresult<T,E>return style.Validation performed
Verified in unit tests.