clp-s: Ensure ArchiveWriterOption is fully initialized when splitting archives.#462
Merged
Merged
Conversation
kirkrodrigues
requested changes
Jun 25, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
At a high level, wouldn't it make more sense to store archive_write_option as a member of JsonParser and then only update the id when splitting an archive?
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
kirkrodrigues
approved these changes
Jun 25, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title, how about:
clp-s: Ensure ArchiveWriterOption is fully initialized when splitting archives.
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
… archives. (y-scope#462) Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
… archives. (y-scope#462) Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a minor bug where after splitting an archive the print-archive-stats option can be set to a random value.
Validation performed