ffi: Add WIP Serializer class for the next IR stream format.#446
Merged
Conversation
gibber9809
previously approved these changes
Jun 21, 2024
gibber9809
left a comment
Contributor
There was a problem hiding this comment.
LGTM. How about "ffi: Add Serializer class for new IR stream format." for the title?
kirkrodrigues
requested changes
Jun 21, 2024
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
kirkrodrigues
approved these changes
Jun 22, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
LGTM. How about "ffi: Add Serializer class for new IR stream format." for the title?
How about a slight update:
ffi: Add WIP Serializer class for the next IR stream format.
Member
Author
lgtm |
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
…#446) Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…#446) Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When migrating to the next IR stream format, there are two important differences:
To adapt to these changes, we wrap all the necessary data structures into a new class named
Serializerto keep track of the states, as well as maintain necessary data structures. In details:Note: this class is designed to provide serialization functionalities only. The upper-level caller should be responsible for writing the serialized bytes into IO streams properly. In addition, it doesn't provide a call to terminate the IR stream. The upper-level caller should decide when to terminate the stream by append
clp::ffi::ir_stream::cProtocol::Eofat the end of the stream.Validation performed
clang-tidychecks for theSerializerimplementation.clang-tidyagainst the unit test file since it is not synchronized with the latest coding guideline.