ffi: Extract some serialization methods for use in other files.#444
Merged
Conversation
kirkrodrigues
requested changes
Jun 16, 2024
kirkrodrigues
approved these changes
Jun 16, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title, how about:
ffi: Extract some serialization methods for use in other files.
Member
Author
lgtm |
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the current IR stream implementation, serialization methods are made as local methods so they cannot be reused in other files. However, some methods are reuseable when we implement the next IR format. This PR moves some of the general methods to util files to make them reusable. Methods moved including:
serialie_metadata: This general method serializes a JSON object as the IR stream metadata. It can be reused when creating a new format IR stream.serialize_int: This general integer sterilization method will be wildly used in integer value encoding in the coming format.Notice that minor refactoring is also introduced to meet our latest coding standard when moving these methods.
Validation performed
Ensured the code can be successfully built with all unit tests passed.