Add log-viewer-webui component with boilerplate Fastify server.#442
Merged
Conversation
junhaoliao
reviewed
Jun 14, 2024
junhaoliao
reviewed
Jun 14, 2024
junhaoliao
previously approved these changes
Jun 14, 2024
junhaoliao
left a comment
Member
There was a problem hiding this comment.
Looks good to me.
I verified all routes with Postman and also ensured all npm scripts added in package.json work, including the lint and test ones. The docs/srv/dev-guide md looks good but we do need to publish the site when we merge, or the docs.yscope.com link in components/log-viewer-webui/README.md won't work.
For the env files, we can create a .env.local file for entering debug config without git tracking it. That can be done in another PR, preferably after we enable the server in the CLP package / Taskfile.
I agree with the PR title as the squashed commit message.
Co-authored-by: Junhao Liao <junhao@junhao.ca>
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
…ope#442) Co-authored-by: Junhao Liao <junhao@junhao.ca>
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…ope#442) Co-authored-by: Junhao Liao <junhao@junhao.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To integrate the log-viewer with the CLP package, we plan to add a new webapp that consists of a React frontend and a Fastify backend:
We will integrate this new webapp with the package by embedding it in an iframe in the webui.
This convoluted implementation is for two reasons:
This PR starts a new component,
log-viewer-webui, which contains this webapp. The webapp currently only contains a boilerplate Fastify app.Note that we haven't yet added the new component to the linting workflow since that requires downloading a new node version which would make the PR a bit bigger.
Validation performed
npm lint:checkpassesnpm testpasses.