clo: Add CLI command to extract a compressed file as IR.#437
Merged
Conversation
� Conflicts: � components/core/src/clp/GlobalMySQLMetadataDB.cpp
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
LinZhihao-723
requested changes
Jun 20, 2024
LinZhihao-723
left a comment
Member
There was a problem hiding this comment.
Ask Haiqi asked, this is a review on CommandLinArguments.hpp/cpp and clo.cpp.
Note that the review is brief, mostly catching micro-level issues. Didn't review it from an architecture level, so the variable naming + API design review might be required (please let me know if I should do a further as well).
kirkrodrigues
approved these changes
Jun 22, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title, how about:
clo: Add CLI command to extract a compressed file as IR.
LinZhihao-723
approved these changes
Jun 22, 2024
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The change refactored clo so it takes in a command and can extract a file split into one or more IR chunks.
clo extracts the IRs to a local file system path, and sends metadata to a mongodb specified by the user input.
Validation performed
The following validation are all performed directly via commandline (as opposed to in a clp package)