core-clp: Refactor streaming_archive::reader::File::find_message_matching_query.#426
Merged
Merged
Conversation
LinZhihao-723
commented
Jun 5, 2024
kirkrodrigues
requested changes
Jun 5, 2024
kirkrodrigues
approved these changes
Jun 5, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title, how about:
core-clp: Refactor streaming_archive::reader::File::find_message_matching_query.
streaming_archive::reader::File::find_message_matching_query.
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR refactors the implementation of query matching in the
clpFile reader. It has two improvements:Querylevel checks out of the subquery traversal loop.Validation performed
Compressed hive-24hr dataset and ran wildcard query "INFOapplic12.62?6application*". Ensured the results returned from
clgdoesn't change after refactoring.