clo: Add orig_file_id and log_event_ix to search results.#424
Merged
Conversation
kirkrodrigues
requested changes
Jun 12, 2024
kirkrodrigues
approved these changes
Jun 12, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title, how about:
clo: Add orig_file_id and log_event_ix to search results.
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Current CLP's search results contain the original message, timestamp and original file path. However, the original file path is not sufficient to identify the file if multiple file shares the same path (if they are from different file system, or they are both rotated log with the same file name).
In this PR, we add file's original id and the log event index to every search result, which allows us to locate the specific file split that contains the matching result.
The change can be viewed as two smaller change:
Note that the new fields are not used in the code yet.
Validation performed
Built the package and compress a log file locally, Verified that