core-clp: Add CLI command to extract a compressed file as IR.#420
Merged
Conversation
� Conflicts: � components/core/src/clp/GlobalMySQLMetadataDB.cpp
kirkrodrigues
requested changes
Jun 11, 2024
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
…r; Refactor new CLI args code.
kirkrodrigues
requested changes
Jun 12, 2024
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
kirkrodrigues
approved these changes
Jun 12, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title, how about:
core-clp: Add CLI command to extract a file from an archive as IR.
Contributor
Author
how about
|
Member
sgtm |
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
based on #417
Description
This changes adds ir decompression execution path to the clp executable.
The PR contains two notable changes:
clp i. The command allows user to decompress a file split to one or multiple IR files, by providing the orig_file_id and a message index. It also let user pick a custom threshold for the uncompressed IR size and a directory to temporarily write IRs to.IrDecompression.cpp. Compared to thedecompression.cpp,Validation performed
To validate the functionality, we compressed a 64MB file into archive(s). We then decompressed it into mulitple IRs, decoded and concatnate them, and did a binary comparison with the original file.
We used two configuration to cover all the possible cases:
Compressed a 64MB hadoop log using smaller encoded file size and archive size, such that it splits the original file into 3 splits across 2 archives. We then decompressed all 3 IRs by running clp 3 times, using different message index
Compressed the 64MB hadoop log using default settings, so only one file and archive was generated. We then decompressed the IR using a 32MB threshold, generating 3 IRs on disk.