clp-s: Fix search bug caused by NarrowTypes (fixes #254)#263
Merged
Conversation
wraymo
previously approved these changes
Feb 15, 2024
wraymo
left a comment
Contributor
There was a problem hiding this comment.
Great PR! One minor thing is about how we initialize values. I guess for class members we will use {}, but for variables declared in a function, I'm not sure if we want to follow the same style. Other than that, it looks good to me.
kirkrodrigues
requested changes
Feb 15, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
Minor writing comments.
| bool matches_exactly(LiteralTypeBitmask mask) override { return m_flags == mask; } | ||
|
|
||
| /** | ||
| * Equal to operator to allow comparison between two column descriptors. |
Member
There was a problem hiding this comment.
Ditto comment about docstring.
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
wraymo
previously approved these changes
Feb 15, 2024
kirkrodrigues
approved these changes
Feb 15, 2024
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #254
Description
This PR fixes a bug in NarrowTypes where we weren't considering an edge case involving not equals operations on string columns. See #254 for more details.
The fix also includes an optimization to avoid blowing up the AST for long not equals clauses on the same column.
Validation performed