fix(helm): Remove unused directory fields from archive_output.storage and stream_output.storage in values.yaml (fixes #2074).#2075
Merged
Conversation
…age` and `stream_output.storage` in `values.yaml` (fixes y-scope#2074).
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughUpdated Helm chart version from 0.2.0-dev.1 to 0.2.0-dev.2, removed unused directory configuration entries from Helm values for archive and stream storage, and corrected the documentation to reflect the updated storage configuration path structure. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hoophalab
approved these changes
Mar 6, 2026
3 tasks
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…age` and `stream_output.storage` in `values.yaml` (fixes y-scope#2074). (y-scope#2075)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
archive_output.storage.directoryandstream_output.storage.directoryin the Helm chart'svalues.yamlare dangling references — they are defined but never consumed by any template. Theconfigmap template hardcodes the directories instead:
clp/tools/deployment/package-helm/templates/configmap.yaml
Line 25 in dbc1799
clp/tools/deployment/package-helm/templates/configmap.yaml
Line 169 in dbc1799
These hardcoded paths (
/var/data/archivesand/var/data/streams) match the PVC mount points, sothe
directoryfields invalues.yamlhave no effect. They appear to be leftovers from when theclp-package used host-mounted directories (removed in #2023).
This PR removes the unused
directoryfields and their comments from botharchive_output.storageandstream_output.storageinvalues.yaml.Checklist
breaking change.
Validation performed
1. Helm template renders identically
Task: Verify that removing the
directoryfields fromvalues.yamldoes not change therendered Kubernetes manifests.
Command:
Output:
Explanation: The rendered configmap still contains the hardcoded
directoryvalues(
/var/data/archivesand/var/data/streams) from the template — these come fromconfigmap.yaml, notvalues.yaml. The output is identical before and after this change.2. No remaining references to removed fields in Helm chart
Task: Verify that no Helm template or helper references the removed
directoryfields.Command:
Output:
Explanation: No templates or helpers reference the removed fields.
Summary by CodeRabbit
Release Notes
Documentation
Chores