Skip to content

fix(helm): Remove Job TTL to prevent init container CrashLoopBackOff on pod restarts (fixes #2043).#2044

Merged
junhaoliao merged 4 commits into
y-scope:mainfrom
junhaoliao:helm-remove-ttl
Mar 2, 2026
Merged

fix(helm): Remove Job TTL to prevent init container CrashLoopBackOff on pod restarts (fixes #2043).#2044
junhaoliao merged 4 commits into
y-scope:mainfrom
junhaoliao:helm-remove-ttl

Conversation

@junhaoliao

@junhaoliao junhaoliao commented Feb 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Remove ttlSecondsAfterFinished: 300 from the db-table-creator and
results-cache-indices-creator Job specs so that Kubernetes never
garbage-collects the completed Job objects.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  1. Ran set-up-test.sh and observed the kind cluster was started.
  2. Performed global search of ttlSecondsAfterFinished and didn't find any occurances.

Summary by CodeRabbit

Release Notes

  • Chores
    • Incremented deployment version to 0.2.0-dev.1
    • Modified background job settings to disable automatic time-based cleanup, affecting job retention behaviour

@coderabbitai

coderabbitai Bot commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44de3d4 and 73f7388.

📒 Files selected for processing (3)
  • tools/deployment/package-helm/Chart.yaml
  • tools/deployment/package-helm/templates/db-table-creator-job.yaml
  • tools/deployment/package-helm/templates/results-cache-indices-creator-job.yaml
💤 Files with no reviewable changes (2)
  • tools/deployment/package-helm/templates/results-cache-indices-creator-job.yaml
  • tools/deployment/package-helm/templates/db-table-creator-job.yaml

Walkthrough

Helm chart version updated from 0.2.0-dev.0 to 0.2.0-dev.1. Removed TTL cleanup settings (ttlSecondsAfterFinished: 300) from two Kubernetes Job specifications in the chart templates.

Changes

Cohort / File(s) Summary
Chart Configuration
tools/deployment/package-helm/Chart.yaml		 Bumped version from 0.2.0-dev.0 to 0.2.0-dev.1.
Job TTL Removal
tools/deployment/package-helm/templates/db-table-creator-job.yaml, tools/deployment/package-helm/templates/results-cache-indices-creator-job.yaml		 Removed ttlSecondsAfterFinished: 300 field from both Job specs, eliminating automatic cleanup timeout settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing Job TTL settings from Helm chart Job specs to fix init container CrashLoopBackOff issues, directly matching the primary objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@junhaoliao junhaoliao changed the title fix(helm): Remove Job TTL to prevent init container CrashLoopBackOff … fix(helm): Remove Job TTL to prevent init container CrashLoopBackOff on pod restarts (fixes #2043). Feb 26, 2026
@junhaoliao junhaoliao requested a review from hoophalab February 26, 2026 22:29
@junhaoliao junhaoliao marked this pull request as ready for review February 27, 2026 06:54
@junhaoliao junhaoliao requested a review from a team as a code owner February 27, 2026 06:54
hoophalab
hoophalab approved these changes Mar 2, 2026
View reviewed changes

@hoophalab hoophalab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@junhaoliao junhaoliao merged commit dcc105c into y-scope:main Mar 2, 2026
23 checks passed
@junhaoliao junhaoliao added this to the February 2026 milestone Mar 3, 2026
@junhaoliao junhaoliao deleted the helm-remove-ttl branch May 7, 2026 19:46
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@junhaoliao
fix(helm): Remove Job TTL to prevent init container CrashLoopBackOff …
ccb83df 
…on pod restarts (fixes y-scope#2043). (y-scope#2044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoophalab hoophalab hoophalab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

February 2026

Development

Successfully merging this pull request may close these issues.

2 participants

@junhaoliao @hoophalab