Skip to content

fix(webui): Use numeric value for VirtualTable scroll.x to fix console warning with dev server (fixes #1892).#1949

Merged
junhaoliao merged 1 commit into
y-scope:mainfrom
junhaoliao:issue-1892
Feb 10, 2026
Merged

fix(webui): Use numeric value for VirtualTable scroll.x to fix console warning with dev server (fixes #1892).#1949
junhaoliao merged 1 commit into
y-scope:mainfrom
junhaoliao:issue-1892

Conversation

@junhaoliao

@junhaoliao junhaoliao commented Feb 2, 2026

Copy link
Copy Markdown
Member

Description

Change scroll.x from true to 1 in the VirtualTable component on the Ingest page to
eliminate the console warning:

Warning: `scroll.x` in virtual table must be number.

rc-table's VirtualTable only accepts number for scroll.x (unlike the regular Table which accepts number | true | string). The value 1 is what rc-table falls back to internally, so this
change preserves the existing behaviour.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

0. Build CLP package

Task: Verify the project builds successfully with the change.

Command:

task

Output:

...
#30 exporting manifest list sha256:9fc6e521f84e4a9333887b0fde4b452d423a0282c8da99f3b0723b667d5b267e 0.0s done
#30 naming to moby-dangling@sha256:9fc6e521f84e4a9333887b0fde4b452d423a0282c8da99f3b0723b667d5b267e done
#30 unpacking to moby-dangling@sha256:9fc6e521f84e4a9333887b0fde4b452d423a0282c8da99f3b0723b667d5b267e done
#30 DONE 7.5s
task: [package] echo '0.8.1-dev' > '/home/junhao/workspace/clp/build/clp-package/VERSION'

Build completed successfully.

1. Start CLP and compress data

Task: Start CLP and run a compression job so the VirtualTable on the Ingest page is populated
with data (the warning only triggers when the table renders rows).

Commands:

cd build/clp-package
./sbin/start-clp.sh
./sbin/compress.sh --timestamp-key timestamp ~/samples/postgresql.jsonl

Output:

...
 Container clp-package-2d7a-webui-1 Healthy
2026-02-01T11:13:19.741 INFO [controller] Started CLP.

2026-02-01T11:14:02.054 INFO [compress] Compression job 1 submitted.
2026-02-01T11:14:04.057 INFO [compress] Compressed 392.84MB into 9.94MB (39.53x). Speed: 204.75MB/s.
2026-02-01T11:14:04.558 INFO [compress] Compression finished.

2. Start the webui dev server

Task: The scroll.x warning only appears in the dev server (the production build suppresses
React warnings). Start the Vite dev server for the webui client.

Commands:

cd components/webui
npm run dev

The Vite client dev server started on http://localhost:8087 and the Fastify server on port 3000.

3. Verify no scroll.x warning with the fix

Task: Open the Ingest page in the browser and check the console for the scroll.x warning.

Opened http://localhost:8087 in Chrome. The page shows the Ingest view with the Compression Jobs
table populated with one completed job. Checked the browser console—no scroll.x warning. The
only console messages are Vite connection logs and a React DevTools notice.

4. Revert the fix and confirm the warning appears

Task: Revert the change (set scroll.x back to true) and confirm the warning reappears.

Reverted components/webui/client/src/pages/IngestPage/Jobs/index.tsx to use scroll={{y: 400, x: true}}. Vite HMR hot-updated the module. The browser console immediately showed:

Warning: `scroll.x` in virtual table must be number.

5. Re-apply the fix and confirm the warning is gone

Task: Re-apply the fix (x: 1) and confirm the warning disappears.

Changed back to scroll={{y: 400, x: 1}}. After Vite HMR and a full page reload, the console
showed no scroll.x warning—only Vite connection logs and the React DevTools notice.

6. Stop CLP

Command:

cd build/clp-package
./sbin/stop-clp.sh

Output:

...
 Network clp-package-2d7a_default Removed
2026-02-01T11:14:42.591 INFO [controller] Stopped CLP.

Summary by CodeRabbit

  • Bug Fixes
    • Improved horizontal scrolling behaviour in data table displays to ensure proper column visibility and user navigation.

✏️ Tip: You can customize this high-level summary in your review settings.

@junhaoliao junhaoliao requested a review from a team as a code owner February 2, 2026 02:51
@junhaoliao junhaoliao requested a review from hoophalab February 2, 2026 02:51
@junhaoliao junhaoliao added this to the Mid-February 2026 milestone Feb 2, 2026
@coderabbitai

coderabbitai Bot commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

A single configuration change to the VirtualTable scroll property in the IngestPage Jobs component, modifying the horizontal scroll option from a boolean value to a numeric value to align with rc-table's API requirements.

Changes

Cohort / File(s) Summary
VirtualTable Scroll Configuration
components/webui/client/src/pages/IngestPage/Jobs/index.tsx
Updated scroll property configuration from { y: 400, x: true } to { y: 400, x: 1 }, changing the horizontal scroll value from boolean to numeric type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • Issue #1892: Addresses the requirement that rc-table's VirtualTable component requires a numeric value for the scroll.x property rather than a boolean value, which this change directly implements.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing a boolean value with a numeric value for VirtualTable's scroll.x property to fix a console warning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@junhaoliao junhaoliao merged commit c42526c into y-scope:main Feb 10, 2026
23 checks passed
Bill-hbrhbr pushed a commit to Bill-hbrhbr/clp that referenced this pull request Feb 10, 2026
@junhaoliao junhaoliao deleted the issue-1892 branch May 7, 2026 19:46
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants