fix(webui): Use numeric value for VirtualTable scroll.x to fix console warning with dev server (fixes #1892).#1949
Merged
Conversation
…ole warning (fixes y-scope#1892).
Contributor
WalkthroughA single configuration change to the VirtualTable scroll property in the IngestPage Jobs component, modifying the horizontal scroll option from a boolean value to a numeric value to align with rc-table's API requirements. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hoophalab
approved these changes
Feb 9, 2026
Bill-hbrhbr
pushed a commit
to Bill-hbrhbr/clp
that referenced
this pull request
Feb 10, 2026
…ole warning with dev server (fixes y-scope#1892). (y-scope#1949)
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…ole warning with dev server (fixes y-scope#1892). (y-scope#1949)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change
scroll.xfromtrueto1in theVirtualTablecomponent on the Ingest page toeliminate the console warning:
rc-table's
VirtualTableonly acceptsnumberforscroll.x(unlike the regularTablewhich acceptsnumber | true | string). The value1is what rc-table falls back to internally, so thischange preserves the existing behaviour.
Checklist
breaking change.
Validation performed
0. Build CLP package
Task: Verify the project builds successfully with the change.
Command:
Output:
Build completed successfully.
1. Start CLP and compress data
Task: Start CLP and run a compression job so the VirtualTable on the Ingest page is populated
with data (the warning only triggers when the table renders rows).
Commands:
Output:
2. Start the webui dev server
Task: The
scroll.xwarning only appears in the dev server (the production build suppressesReact warnings). Start the Vite dev server for the webui client.
Commands:
cd components/webui npm run devThe Vite client dev server started on
http://localhost:8087and the Fastify server on port 3000.3. Verify no
scroll.xwarning with the fixTask: Open the Ingest page in the browser and check the console for the
scroll.xwarning.Opened
http://localhost:8087in Chrome. The page shows the Ingest view with the Compression Jobstable populated with one completed job. Checked the browser console—no
scroll.xwarning. Theonly console messages are Vite connection logs and a React DevTools notice.
4. Revert the fix and confirm the warning appears
Task: Revert the change (set
scroll.xback totrue) and confirm the warning reappears.Reverted
components/webui/client/src/pages/IngestPage/Jobs/index.tsxto usescroll={{y: 400, x: true}}. Vite HMR hot-updated the module. The browser console immediately showed:5. Re-apply the fix and confirm the warning is gone
Task: Re-apply the fix (
x: 1) and confirm the warning disappears.Changed back to
scroll={{y: 400, x: 1}}. After Vite HMR and a full page reload, the consoleshowed no
scroll.xwarning—only Vite connection logs and the React DevTools notice.6. Stop CLP
Command:
cd build/clp-package ./sbin/stop-clp.shOutput:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.