fix(clp-package): Remove unused staged-streams volume mount from the api-server service (fixes #1810).#1947
Merged
Merged
Conversation
…om API server (fixes y-scope#1810).
Contributor
WalkthroughA volume mapping is removed from the api-server service in the Docker Compose configuration file. The staged-streams directory mount from the host is no longer included in the container's volume definitions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hoophalab
approved these changes
Feb 9, 2026
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…api-server service (fixes y-scope#1810). (y-scope#1947)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
staged-streamsvolume mount from theapi-serverservice indocker-compose-all.yaml. The API server does not read or write staged streams; only the query-worker requires this mount.Checklist
breaking change.
Validation performed
0. Build CLP package
Command:
Build completed successfully.
1. Start CLP and verify container mounts
Configured
clp-config.yamlwith S3 storage forstream_outputtoexercise the staged-streams path:
Command:
All containers started and passed health checks.
API server mounts (
docker inspect --format '{{range .Mounts}}...'):No
staged-streamsmount on the API server.Query-worker mounts:
The query-worker retains
/var/data/staged-streams.2. Compress data and query via the API server
Compressed sample data (
./sbin/compress.sh), then submitted a search query and fetched results directly from the API server's/query_resultsSSE endpoint:The API server successfully read query results from S3 without the
staged-streamsmount.3. Stop CLP
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.