fix(helm): Ensure log_ingestor is explicitly null in configmap when disabled (fixes #1881).#1882
Merged
Merged
Conversation
Contributor
WalkthroughBumps Helm Chart version from "0.1.2-dev.18" to "0.1.2-dev.19" and adds a conditional else branch to the log_ingestor configuration block in the configmap template, setting the value to null when the condition is not met. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
16 tasks
LinZhihao-723
approved these changes
Jan 19, 2026
3 tasks
This was referenced Jan 26, 2026
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
… disabled (fixes y-scope#1881). (y-scope#1882)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
This PR is part of the ongoing work for #1309. More PRs will be submitted until the Helm chart is complete and fully functional.
Sets the
log_ingestorintools/deployment/package-helm/templates/configmap.yamlasnullwhen thelog_ingestoris configured to be disabled (alsonull) invalues.yaml.Checklist
breaking change.
Validation performed
Applied below changes to values.yaml:
Ran tools/deployment/package-helm/set-up-test.sh and observed "All jobs completed and services are ready."
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.