feat(kv-ir)!: Add support for matching KQL timestamp literals against integer and float values. by gibber9809 · Pull Request #1848 · y-scope/clp

gibber9809 · 2026-01-07T21:10:52Z

Description

This PR updates the mapping between kv-ir stream schema tree nodes and literal types in order to allow timestamp literals to match floats, integers, and nothing else.

In practice for the current way ASTs are generated from KQL and refined this was already possible (since timestamp literals can be converted to integer and float literals), but this PR makes the mapping more explicit and adds tests.

Checklist

The PR satisfies the contribution guidelines.
This is a breaking change and that has been indicated in the PR title, OR this isn't a
breaking change.
Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Added tests to ensure that timestamp literals work as expected for column resolution and search.
Manually validated that timestamps in kv-ir streams can be searched as expected using timestamp literals in the clp-s cli.

Summary by CodeRabbit

Release Notes

Tests
- Enhanced timestamp expression support in search query validation.
- Extended test coverage for timestamp literal handling with various filter operations.
Internal Updates
- Refined type mapping for timestamp handling in search utilities.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…loat and integer columns.

…l-search

coderabbitai · 2026-01-07T21:11:04Z

Walkthrough

These changes extend timestamp literal support in search functionality tests and utilities. Modifications include adding timestamp-formatted KQL expressions to test cases, introducing TimestampLiteral test operands with filter operations, and updating type mappings to include TimestampT in numeric literal types.

Changes

Cohort / File(s)	Summary
Test Query Handler Expressions `components/core/src/clp/ffi/ir_stream/search/test/test_QueryHandlerImpl.cpp`	Adds timestamp-formatted KQL expressions (`<column>: timestamp("<value>")`) to matchable expressions for both Int and Float node test cases, expanding the set of testable filter representations.
Test Utilities & Operands `components/core/src/clp/ffi/ir_stream/search/test/test_utils.cpp`	Introduces TimestampLiteral test operand support with includes, using declarations, and extends filter operation test coverage (EQ, NEQ, LT, LTE, GT, GTE) for timestamp scenarios alongside existing literal types. Updates test matrices to map timestamp evaluations to appropriate literal types (IntegerT, FloatT).
Type Mapping Utility `components/core/src/clp/ffi/ir_stream/search/utils.cpp`	Updates `schema_tree_node_type_to_literal_types` function to include TimestampT in numeric type handling: adds TimestampT to IntegerT for Int nodes and to FloatT for Float nodes; removes TimestampT from Str case.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the main change: adding support for matching KQL timestamp literals against integer and float values, which aligns with the PR's core modifications across all three modified files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

LinZhihao-723

The code changes lgtm. My only concern is that this implementation will no longer allow comparing timestamp literal against an unparsed string representation. We should probably create an issue to keep track of this.
For the PR title, how about:

feat(kv-ir)!: Add support for matching KQL timestamp literals against integer and float values.

I feel like we should mark this as a breaking change since it changes the search behavior.

gibber9809 · 2026-01-08T15:05:31Z

The code changes lgtm. My only concern is that this implementation will no longer allow comparing timestamp literal against an unparsed string representation. We should probably create an issue to keep track of this. For the PR title, how about:
feat(kv-ir)!: Add support for matching KQL timestamp literals against integer and float values.
I feel like we should mark this as a breaking change since it changes the search behavior.

Makes sense. Yeah I figured it was better to just drop the string comparison support for now until we have time to do it properly -- created #1851 to track.

… integer and float values. (y-scope#1848)

gibber9809 added 3 commits January 5, 2026 20:44

Change how timestamp literal types map to ffi schema tree node types.

7147b55

Test that timestamp literals have expected search behaviour against f…

a33b19d

…loat and integer columns.

Merge remote-tracking branch 'upstream/main' into ir-timestamp-litera…

1c35e22

…l-search

gibber9809 requested a review from a team as a code owner January 7, 2026 21:10

gibber9809 requested a review from LinZhihao-723 January 7, 2026 21:11

LinZhihao-723 approved these changes Jan 8, 2026

View reviewed changes

gibber9809 mentioned this pull request Jan 8, 2026

feat(kv-ir): Add support for comparing timestamp literals against string columns. #1851

Open

gibber9809 changed the title ~~feat(kv-ir): Allow timestamp literals to match integer and float columns during search.~~ feat(kv-ir)!: Add support for matching KQL timestamp literals against integer and float values. Jan 8, 2026

Merge branch 'main' into ir-timestamp-literal-search

fdcf00d

gibber9809 merged commit 19bb18f into y-scope:main Jan 8, 2026
26 checks passed

davidlion pushed a commit to davidlion/clp that referenced this pull request Jan 17, 2026

feat(kv-ir)!: Add support for matching KQL timestamp literals against…

8e9628a

… integer and float values. (y-scope#1848)

junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026

feat(kv-ir)!: Add support for matching KQL timestamp literals against…

55b3d70

… integer and float values. (y-scope#1848)

junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026

feat(kv-ir)!: Add support for matching KQL timestamp literals against…

546c3c7

… integer and float values. (y-scope#1848)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(kv-ir)!: Add support for matching KQL timestamp literals against integer and float values.#1848

feat(kv-ir)!: Add support for matching KQL timestamp literals against integer and float values.#1848
gibber9809 merged 4 commits into
y-scope:mainfrom
gibber9809:ir-timestamp-literal-search

gibber9809 commented Jan 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

LinZhihao-723 left a comment

Uh oh!

gibber9809 commented Jan 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gibber9809 commented Jan 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Validation performed

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

LinZhihao-723 left a comment

Choose a reason for hiding this comment

Uh oh!

gibber9809 commented Jan 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gibber9809 commented Jan 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 7, 2026 •

edited

Loading