Skip to content

fix(helm): Add missing spider database name configuration (fixes #1845).#1846

Merged
junhaoliao merged 2 commits into
y-scope:mainfrom
junhaoliao:helm-fix-spider-db-name
Jan 7, 2026
Merged

fix(helm): Add missing spider database name configuration (fixes #1845).#1846
junhaoliao merged 2 commits into
y-scope:mainfrom
junhaoliao:helm-fix-spider-db-name

Conversation

@junhaoliao

@junhaoliao junhaoliao commented Jan 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Note

This PR is part of the ongoing work for #1309. More PRs will be submitted until the Helm chart is complete and fully functional.

Fix the API deployment launch failure in the Package Helm chart by adding the missing key spider in the database.names config.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

cd tools/deployment/package-helm
./test.sh 
# Output: All jobs completed and services are ready.

Summary by CodeRabbit

  • Chores
    • Bumped deployment configuration version
    • Extended database configuration mappings to include an additional database entry

✏️ Tip: You can customize this high-level summary in your review settings.

@junhaoliao junhaoliao requested a review from a team as a code owner January 7, 2026 19:54
@coderabbitai

coderabbitai Bot commented Jan 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request updates the Helm chart configuration to add support for a spider database. It includes a version bump to the chart and introduces spider database name mappings in both the configmap template and values file.

Changes

Cohort / File(s) Summary
Chart version
tools/deployment/package-helm/Chart.yaml		 Version incremented from 0.1.2-dev.14 to 0.1.2-dev.15
Database configuration
tools/deployment/package-helm/templates/configmap.yaml, tools/deployment/package-helm/values.yaml		 Added spider database name mapping; spider field now rendered in configmap from .Values.clpConfig.database.names.spider with value "spider-db"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a missing spider database name configuration to the Helm chart.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 356d08d and 6621e76.

📒 Files selected for processing (3)
  • tools/deployment/package-helm/Chart.yaml
  • tools/deployment/package-helm/templates/configmap.yaml
  • tools/deployment/package-helm/values.yaml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-25T05:13:13.298Z 
Learnt from: junhaoliao
Repo: y-scope/clp PR: 1178
File: components/clp-package-utils/clp_package_utils/controller.py:217-223
Timestamp: 2025-09-25T05:13:13.298Z
Learning: The compression scheduler service in CLP runs with CLP_UID_GID (current user's UID:GID) rather than CLP_SERVICE_CONTAINER_UID_GID (999:999), unlike infrastructure services such as database, queue, redis, and results cache which run with the service container UID:GID.

Applied to files:

  • tools/deployment/package-helm/values.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: package-image
  • GitHub Check: lint-check (ubuntu-24.04)
  • GitHub Check: check-generated
  • GitHub Check: lint-check (macos-15)
🔇 Additional comments (3)
tools/deployment/package-helm/Chart.yaml (1)

3-3: LGTM! Appropriate version bump.

The chart version increment is appropriate for this configuration fix.

tools/deployment/package-helm/templates/configmap.yaml (1)

56-56: LGTM! Proper template rendering.

The spider database name is correctly rendered using the same pattern as the clp database name, with proper quoting for YAML safety.

tools/deployment/package-helm/values.yaml (1)

50-50: LGTM! Properly integrated and follows established patterns.

The spider database name configuration is correctly added to the Helm values and properly referenced in the configmap template. The docker-compose services (spider-scheduler and spider-compression-worker) reference the spider database with appropriate environment variable defaults (SPIDER_DB_NAME and SPIDER_DB_USER).

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Jan 7, 2026
Closed
Merged
Merged
Merged
@junhaoliao junhaoliao merged commit 4d14db8 into y-scope:main Jan 7, 2026
20 checks passed
davidlion pushed a commit to davidlion/clp that referenced this pull request Jan 17, 2026
@junhaoliao @davidlion
fix(helm): Add missing spider database name configuration (fixes y-sc…
ebb28fc 
…ope#1845). (y-scope#1846)
@junhaoliao junhaoliao deleted the helm-fix-spider-db-name branch May 7, 2026 19:46
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@junhaoliao @davidlion
fix(helm): Add missing spider database name configuration (fixes y-sc…
948aeff 
…ope#1845). (y-scope#1846)
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@junhaoliao
fix(helm): Add missing spider database name configuration (fixes y-sc…
6b7154c 
…ope#1845). (y-scope#1846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sitaowang1998 sitaowang1998 sitaowang1998 approved these changes

@LinZhihao-723 LinZhihao-723 Awaiting requested review from LinZhihao-723

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junhaoliao @sitaowang1998