fix(clp-mcp-server): Replace database.name with database.names.clp (fixes #1820).#1821
Conversation
…DbNameType.CLP]` (fixes y-scope#1820).
WalkthroughA single file in the CLP MCP server connector module is modified to access the MariaDB database name through a named mapping using Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
PR #1606 changed the database configuration interface from
database.name(single string) todatabase.names(dictionary withClpDbNameType.CLPandClpDbNameType.SPIDERkeys). The MCPserver was not updated to use this new interface, causing an
AttributeErroron startup.This PR updates
clp_connector.pyto use the new interface.Checklist
breaking change.
Validation performed
Built the project:
Configured the MCP server in
build/clp-package/etc/clp-config.yaml:Started the CLP package:
cd build/clp-package ./sbin/start-clp.shCompressed sample logs:
./sbin/compress.sh --timestamp=timestamp ~/samples/postgresql.jsonlOutput:
Verified the MCP server is alive:
Output:
Initialized an MCP session:
Output (note the
mcp-session-idheader):Listed available MCP tools:
Output:
Invoked the
get_instructionstool (required before other tools):Output:
Invoked the
search_by_kqltool:Output:
✅ Observed results are getting returned.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.