refactor(helm): Remove unused query_scheduler.port from values.yaml (resolves #1812).#1815
Merged
Merged
Conversation
Contributor
WalkthroughChart version bumped and an unused query_scheduler port entry removed from Helm values; no other functional changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sitaowang1998
previously approved these changes
Dec 19, 2025
sitaowang1998
approved these changes
Dec 19, 2025
16 tasks
davidlion
pushed a commit
to davidlion/clp
that referenced
this pull request
Jan 17, 2026
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
This PR is part of the ongoing work for #1309. More PRs will be submitted until the Helm chart is complete and fully functional.
Resolves #1812 by removing the unused
port: 7000configuration from thequery_schedulersection invalues.yaml.The query-scheduler port is an internal value that is hardcoded to 7000 in the templates (
configmap.yamlandquery-scheduler-deployment.yaml). Exposing it invalues.yamlis misleading since changing the value would have no effect - the port is not user-facing and does not need to be configurable.This aligns with the established pattern where internal services (query-scheduler, reducer) have hardcoded ports, while only user-facing and sbin-accessible services have configurable ports.
Checklist
breaking change.
Validation performed
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.