Skip to content

refactor(webui): Restructure directory hierarchy to better separate Presto and native components.#1724

Merged
davemarco merged 9 commits into
y-scope:mainfrom
davemarco:prestoRefactor
Dec 8, 2025
Merged

refactor(webui): Restructure directory hierarchy to better separate Presto and native components.#1724
davemarco merged 9 commits into
y-scope:mainfrom
davemarco:prestoRefactor

Conversation

@davemarco

@davemarco davemarco commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Description

Some of the folders in the webui were getting cluttered as the project grows. This PR restructures certain directories to move native components into their own directories. Components that are shared in common with presto remain in the main directory. Longer term we may completely separate the native and presto directory trees, and have a shared components folder, but this will be larger refactor. For now, this PR makes the current structure less cluttered, and will make a future larger refactor easier.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Webui started

Summary by CodeRabbit

  • Chores
    • Reorganised internal module structure and refactored import paths across all search interface components, including progress tracking, query input mechanisms, search controls, results visualisation tables, and timeline displays. These structural improvements enhance overall code organisation and maintainability throughout the search functionality while fully preserving all existing user-facing features, capabilities, and experience.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request reorganizes the SearchPage component structure by consolidating variant-specific implementations under dedicated subdirectories. Files are relocated into "Native" subdirectories, and import paths are updated throughout the codebase to reflect the new directory hierarchy.

Changes

Cohort / File(s) Summary
Module Relocations
components/webui/client/src/pages/SearchPage/SearchControls/index.tsx, components/webui/client/src/pages/SearchPage/SearchControls/Native/NativeControls.tsx, components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTable/index.tsx, components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTable/Native/..., components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTimeline/index.tsx, components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTimeline/Native/NativeResultsTimeline.tsx
Component files moved to "Native" subdirectories; parent index files updated to reference new paths.
SearchControls Native Imports
components/webui/client/src/pages/SearchPage/SearchControls/Native/QueryInput/index.tsx, components/webui/client/src/pages/SearchPage/SearchControls/Native/SearchButton/CancelButton.tsx, components/webui/client/src/pages/SearchPage/SearchControls/Native/SearchButton/SubmitButton/index.tsx, components/webui/client/src/pages/SearchPage/SearchControls/Native/SearchButton/index.tsx, components/webui/client/src/pages/SearchPage/SearchControls/Native/search-requests.ts
Import paths adjusted to reflect deeper nesting in directory structure; paths incremented by one or more directory levels.
SearchResults Native Imports
components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTable/Native/Message/LogViewerLink.tsx, components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTable/Native/Message/index.tsx, components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTable/Native/SearchResultsVirtualTable/..., components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTable/Native/utils.ts
Import paths updated to account for deeper nesting in Native subdirectory; path depth adjusted accordingly.
SearchResultsTimeline Native Imports
components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTimeline/Native/NativeResultsTimeline.tsx, components/webui/client/src/pages/SearchPage/SearchResults/SearchResultsTimeline/Native/useAggregationResults.ts
Import paths updated to reflect relocation to Native subdirectory; module resolution adjusted one level deeper.
Top-level SearchPage Updates
components/webui/client/src/pages/SearchPage/ProgressBar/index.tsx, components/webui/client/src/pages/SearchPage/index.tsx
ProgressBar import updated; relative paths adjusted for new component organization.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Areas requiring attention:
    • Verify all import paths resolve correctly across the reorganized directory structure
    • Confirm that no circular dependencies were introduced by the deeper nesting
    • Check that relative path adjustments in files two or more levels deep are accurate (e.g., search-requests.ts, utility files in SearchResultsVirtualTable/)
    • Validate that the reorganization maintains consistent patterns across all three "Native" subdirectories

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately reflects the main objective of restructuring the directory hierarchy to separate Presto and native components, which aligns with all the file changes in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@davemarco davemarco requested a review from hoophalab December 3, 2025 18:30
@davemarco davemarco marked this pull request as ready for review December 3, 2025 18:30
@davemarco davemarco requested a review from a team as a code owner December 3, 2025 18:30

@hoophalab hoophalab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoophalab hoophalab requested a review from junhaoliao December 4, 2025 18:57

@junhaoliao junhaoliao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deferring to @hoophalab 's review

@davemarco davemarco merged commit 21fa311 into y-scope:main Dec 8, 2025
19 checks passed
davidlion pushed a commit to davidlion/clp that referenced this pull request Jan 17, 2026
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants