Skip to content

fix(deployment): Always pull the latest image and use the correct tag in the CLP package Helm Chart (fixes #1699).#1700

Merged
junhaoliao merged 8 commits into
y-scope:mainfrom
junhaoliao:helm-image-policy
Dec 8, 2025
Merged

fix(deployment): Always pull the latest image and use the correct tag in the CLP package Helm Chart (fixes #1699).#1700
junhaoliao merged 8 commits into
y-scope:mainfrom
junhaoliao:helm-image-policy

Conversation

@junhaoliao

@junhaoliao junhaoliao commented Nov 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Note

This PR is part of the ongoing work for #1309. More PRs will be submitted until the Helm chart is complete and fully functional.

The following configurations were updated:

  • image.clpPackage.pullPolicy: Changed from "IfNotPresent" to "Always"
  • image.clpPackage.tag: Changed from "nightly" to "main"

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

# ./test.sh
# kubectl get pod test-clp-db-table-creator-c4flr -o jsonpath='{range .status.containerStatuses[*]}{.name}{"\t"}{.imageID}{"\n"}{end}'
db-table-creator        ghcr.io/y-scope/clp/clp-package@sha256:f59eac311c5092ce1020b5728ae62142f48afe4eb146c27cfc6321e15af194f7

Summary by CodeRabbit

  • Chores
    • Bumped Helm chart version to reflect updated deployment metadata.
    • Set container image pull policy to Always to ensure fresh images on deploy.
    • Switched container image reference from nightly to main to align deployments with the primary branch.

✏️ Tip: You can customize this high-level summary in your review settings.

@junhaoliao junhaoliao requested a review from a team as a code owner November 29, 2025 08:59
@coderabbitai

coderabbitai Bot commented Nov 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Chart version in tools/deployment/package-helm/Chart.yaml is incremented and the CLP package image settings in tools/deployment/package-helm/values.yaml are changed to always pull and use the main tag instead of nightly.

Changes

Cohort / File(s) Summary
Helm chart metadata
tools/deployment/package-helm/Chart.yaml		 Bumped chart version from 0.1.1 to 0.1.2-dev.1.
Helm values (image config)
tools/deployment/package-helm/values.yaml		 Updated image.clpPackage.pullPolicy from IfNotPresent → Always; updated image.clpPackage.tag from nightly → main.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Files/areas to spot-check:

  • tools/deployment/package-helm/values.yaml — confirm image.clpPackage.pullPolicy and tag match deployment intent (CI/main images vs nightly).
  • tools/deployment/package-helm/Chart.yaml — verify chart version format and alignment with release process.

Possibly related issues

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: updating image pull policy to 'Always' and changing the tag from 'nightly' to 'main' in the Helm Chart, which matches the actual modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

kirkrodrigues
kirkrodrigues reviewed Dec 4, 2025
View reviewed changes

@kirkrodrigues kirkrodrigues left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this except the version bump as we're discussing here: #1725 (comment)

For the PR title, how about:

fix(deployment): Always pull the latest image and use the correct tag in the CLP package Helm Chart (fixes #1699).

@junhaoliao

junhaoliao commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'm fine with this except the version bump as we're discussing here: #1725 (comment)

For the PR title, how about:

fix(deployment): Always pull the latest image and use the correct tag in the CLP package Helm Chart (fixes #1699).

responded at #1725 (comment)

@junhaoliao junhaoliao changed the title fix(deployment): Update the CLP Package image pull policy and tag in the Helm chart (fixes #1699). fix(deployment): Always pull the latest image and use the correct tag in the CLP package Helm Chart (fixes #1699). Dec 4, 2025
@junhaoliao junhaoliao merged commit 92cb7c5 into y-scope:main Dec 8, 2025
19 checks passed
@junhaoliao junhaoliao deleted the helm-image-policy branch May 7, 2026 19:46
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@junhaoliao
fix(deployment): Always pull the latest image and use the correct tag…
470dd32 
… in the CLP package Helm Chart (fixes y-scope#1699). (y-scope#1700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junhaoliao @kirkrodrigues