fix(api-server): Repair logging setup and enhance observability:#1695
Conversation
WalkthroughLogging setup now returns and retains a tracing_appender non-blocking writer guard; QueryConfig gains a Debug derive; additional tracing added around query submission and result streaming (including malformed SSE line handling); api_server RUST_LOG default changed from DEBUG to INFO. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
INFO.Description
The existing API server logging setup is broken and this PR is to fix the following problems:
DEBUGlog would only contain sqlx's log, which is very noisy as we probably don't need the actual SQL executed for debugging. This PR sets the log level toINFOto make the log concise.Checklist
breaking change.
Validation performed
Logs:
Summary by CodeRabbit
Chores
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.