Skip to content

fix(clp-package): Restore missing env var CLP_QUEUE_LOGS_DIR_HOST in the queue service's bundling setup method (fixes #1693).#1694

Merged
junhaoliao merged 1 commit into
y-scope:mainfrom
junhaoliao:fix-env-var
Nov 29, 2025
Merged

Conversation

@junhaoliao

@junhaoliao junhaoliao commented Nov 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

During the refactoring in PR #1648, the CLP_QUEUE_LOGS_DIR_HOST environment variable was accidentally removed from the _set_up_env_for_queue method in components/clp-package-utils/clp_package_utils/controller.py. This PR brings it back

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

task

cd build/clp-package
./sbin/start-clp.sh
# observe the whole package, including the queue was started successfully
# inspect `.env` and found `CLP_QUEUE_LOGS_DIR_HOST` was set

./sbin/stop-clp.sh
rm -f .env
./sbin/start-clp.sh --setup-only
# again inspect `.env` and found `CLP_QUEUE_LOGS_DIR_HOST` was set

@junhaoliao junhaoliao requested a review from a team as a code owner November 29, 2025 00:54
@coderabbitai

coderabbitai Bot commented Nov 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

A new environment variable CLP_QUEUE_LOGS_DIR_HOST is added to the environment setup in the controller module. This variable represents the host path of the queue logs directory and is included in the environment dictionary used for queue bundling operations.

Changes

Cohort / File(s) Summary
Queue Logs Directory Configuration
components/clp-package-utils/clp_package_utils/controller.py		 Added new environment variable CLP_QUEUE_LOGS_DIR_HOST to the environment setup for queue bundling to specify the host path of the queue logs directory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple environment variable addition with no logic changes
  • Single file modification
  • Configuration-only change with minimal complexity

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: restoring a missing environment variable to the queue service's bundling setup method, with a reference to the related issue.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@junhaoliao junhaoliao merged commit eb45ee7 into y-scope:main Nov 29, 2025
22 of 23 checks passed
@junhaoliao junhaoliao deleted the fix-env-var branch November 29, 2025 01:49
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@junhaoliao
fix(clp-package): Restore missing env var CLP_QUEUE_LOGS_DIR_HOST i…
8724865 
…n the queue service's bundling setup method (fixes y-scope#1693). (y-scope#1694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sitaowang1998 sitaowang1998 sitaowang1998 approved these changes

@hoophalab hoophalab Awaiting requested review from hoophalab

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junhaoliao @sitaowang1998