refactor(clp-package)!: Update user in credentials config file for consistency (resolves #1609):#1610
Merged
junhaoliao merged 2 commits intoNov 17, 2025
Conversation
…of `user`; Update values in the credentials template (fixes y-scope#1609).
Contributor
WalkthroughA coordinated refactoring standardizes credential field naming from "user" to "username" across credential generation, configuration loading, template definitions, and deployment scripts for database and queue components, while Redis credentials remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Isn't this a breaking change? |
usernames instead of user; Update values in the credentials template (fixes #1609).usernames instead of user; Update values in the credentials template (fixes #1609).
usernames instead of user; Update values in the credentials template (fixes #1609).usernames instead of user; Update values in the credentials template (resolves #1609).
kirkrodrigues
approved these changes
Nov 17, 2025
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title & body, how about:
refactor(clp-package)!: Update `user` in credentials config file for consistency: (resolves #1609)
- Rename `user` to `username`.
- Update default user to `clp-user` in template credentials.
usernames instead of user; Update values in the credentials template (resolves #1609).user in credentials config file for consistency (resolves #1609):
3 tasks
junhaoliao
added a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…consistency (resolves y-scope#1609): (y-scope#1610) - Rename `user` to `username`. - Update default user to `clp-user` in template credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usertousername.clp-userin template credentials.Description
This PR introduces a
BREAKINGchange:databaseandredisusernames must now be configured under theusernamefields inetc/credentials.ymlwithin the CLP package. e.g.,etc/credentials.yml:The PR fixes inconsistency where credential key names and default values differed between the template file, Pydantic config objects, and auto-generated credentials. All components now consistently use
usernameas the key name withclp-useras the default value.Changes:
credentials.template.ymlto showusername: "clp-user"(instead ofuser: "user")clp_config.pyto readdatabase.usernameandqueue.usernamefrom YAMLgeneral.pyto generate credentials withusernamekeys andclp-useras defaultdatabase.usernameand renamed variable todatabase_usernameChecklist
breaking change.
Validation performed
usernamekeysclp-user) match auto-generated credentialsusername: "clp-user"format)userkey formatSummary by CodeRabbit
Release Notes