Skip to content

feat(webui): Reorganize layout of guided and freeform Presto UI.#1578

Merged
davemarco merged 4 commits into
y-scope:mainfrom
davemarco:ui_new
Nov 12, 2025
Merged

feat(webui): Reorganize layout of guided and freeform Presto UI.#1578
davemarco merged 4 commits into
y-scope:mainfrom
davemarco:ui_new

Conversation

@davemarco

@davemarco davemarco commented Nov 10, 2025 •
edited by junhaoliao
Loading

Copy link
Copy Markdown
Contributor

Description

Reoganizes layout per new design. Another PR will be put up to change freeform button into Antd segmented component.

Screenshot 2025-11-10 at 12 13 33 PM Screenshot 2025-11-10 at 12 15 12 PM

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Summary by CodeRabbit

  • Style
    • Reorganized search control layout, positioning query execution buttons in a dedicated row above the input field.
    • Restructured query status display into a separate section for improved visual organization and clarity.

@coderabbitai

coderabbitai Bot commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes reorganize the layout of search control components by moving action buttons into a new "runRow" container positioned above query inputs, consolidating status displays into separate containers, and adjusting grid layout parameters for improved spacing.

Changes

Cohort / File(s) Summary
Component layout restructuring
components/webui/client/src/pages/SearchPage/SearchControls/Presto/FreeformControls.tsx, components/webui/client/src/pages/SearchPage/SearchControls/Presto/GuidedControls/index.tsx		 Relocated SqlInterfaceButton and SqlSearchButton into a new runRow container positioned above query inputs; separated QueryStatus into its own dedicated status container; removed statusAndButtonsRow element.
CSS layout adjustments
components/webui/client/src/pages/SearchPage/SearchControls/Presto/GuidedControls/index.module.css		 Increased grid column span for .from from 1 to 2; changed .timestampKey from grid-column span to fixed width of 300px.
SearchControls module styling
components/webui/client/src/pages/SearchPage/SearchControls/index.module.css		 Renamed CSS class statusAndButtonsRow to runRow while maintaining identical style properties.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Primarily mechanical reorganization of existing UI components without new logic
  • CSS changes are straightforward (class rename and minor layout parameters)
  • Changes follow a consistent refactoring pattern across files
  • No complex interactions or control-flow modifications

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: reorganizing the layout of UI components in the guided and freeform Presto interface.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@davemarco davemarco marked this pull request as ready for review November 10, 2025 19:01
@davemarco davemarco requested a review from a team as a code owner November 10, 2025 19:01
hoophalab
hoophalab approved these changes Nov 11, 2025
View reviewed changes

@hoophalab hoophalab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoophalab hoophalab requested a review from junhaoliao November 11, 2025 21:13
junhaoliao
junhaoliao approved these changes Nov 11, 2025
View reviewed changes

@junhaoliao junhaoliao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deferring to @hoophalab 's review

@davemarco davemarco merged commit e276511 into y-scope:main Nov 12, 2025
19 checks passed
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@davemarco
feat(webui): Reorganize layout of guided and freeform Presto UI. (y-s…
728661f 
…cope#1578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

@hoophalab hoophalab hoophalab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davemarco @junhaoliao @hoophalab