Skip to content

fix(clp-package): Remove v prefix from the package container image's version tag (fixes #1576).#1577

Merged
kirkrodrigues merged 1 commit into
y-scope:mainfrom
kirkrodrigues:fix-1576
Nov 10, 2025
Merged

fix(clp-package): Remove v prefix from the package container image's version tag (fixes #1576).#1577
kirkrodrigues merged 1 commit into
y-scope:mainfrom
kirkrodrigues:fix-1576

Conversation

@kirkrodrigues

@kirkrodrigues kirkrodrigues commented Nov 10, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

As the title says.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Set G_PACKAGE_VERSION to 0.6.0 in taskfile.yaml
  • task
  • cd build/clp
  • rm clp-package-image.id
  • sbin/start-clp.sh

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated container image version tag format to remove the "v" prefix, aligning with standard versioning conventions.

@kirkrodrigues kirkrodrigues requested a review from a team as a code owner November 10, 2025 04:49
@coderabbitai

coderabbitai Bot commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request modifies the container image tag format in a shell configuration script, removing the "v" prefix from the version string in the image reference derivation, changing from v$version to $version.

Changes

Cohort / File(s) Summary
Container image tag format update
components/package-template/src/sbin/.common-env.sh		 Removed "v" prefix from version tag in container image reference; tag format changed from ghcr.io/y-scope/clp/clp-package:v$version to ghcr.io/y-scope/clp/clp-package:$version

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line string format modification with no logic changes or error-handling impacts

Possibly related issues

  • Issue #1576: Addresses the same container image tag prefix inconsistency in the identical file and code location (components/package-template/src/sbin/.common-env.sh), likely representing a coordinated fix for the version tag format mismatch

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing the 'v' prefix from the package container image's version tag, directly matching the file modification shown in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ff94f8 and a17a0c0.

📒 Files selected for processing (1)
  • components/package-template/src/sbin/.common-env.sh (1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings 
Learnt from: junhaoliao
Repo: y-scope/clp PR: 0
File: :0-0
Timestamp: 2025-10-22T21:02:31.113Z
Learning: Repository y-scope/clp: Maintain deterministic CI/builds for Rust; add a check to verify Cargo.lock is in sync with Cargo.toml without updating dependencies (non-mutating verification in clp-rust-checks workflow).

Learnt from: Bill-hbrhbr
Repo: y-scope/clp PR: 1156
File: components/core/CMakeLists.txt:772-772
Timestamp: 2025-08-09T04:07:27.083Z
Learning: In the CLP project's CMakeLists.txt, when reviewing changes related to the ${zstd_TARGET} variable usage in test linking, the team is planning a refactoring PR to improve this mechanism. Guards for undefined target variables should be deferred to that separate PR rather than being added in focused dependency migration PRs.

Learnt from: junhaoliao
Repo: y-scope/clp PR: 1405
File: components/clp-package-utils/pyproject.toml:5-15
Timestamp: 2025-10-13T03:24:35.074Z
Learning: In the y-scope/clp repository, the Python 3.9 to 3.10 version requirement change was intentionally deferred to a separate PR (after PR #1405) to reduce review effort, as decided in an offline discussion between junhaoliao and kirkrodrigues.

Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/build.sh:18-24
Timestamp: 2025-07-01T14:52:02.418Z
Learning: In the CLP project, consistency across platform build scripts is prioritized over defensive programming when it comes to git remote handling. All build.sh files in docker-images directories should follow the same pattern for git metadata injection.

Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/build.sh:18-24
Timestamp: 2025-07-01T14:52:02.418Z
Learning: In the CLP project, consistency across platform build scripts is prioritized over defensive programming when it comes to git remote handling. All build.sh files in docker-images directories should follow the same pattern for git metadata injection.
📚 Learning: 2025-07-01T14:52:02.418Z 
Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/build.sh:18-24
Timestamp: 2025-07-01T14:52:02.418Z
Learning: In the CLP project, consistency across platform build scripts is prioritized over defensive programming when it comes to git remote handling. All build.sh files in docker-images directories should follow the same pattern for git metadata injection.

Applied to files:

  • components/package-template/src/sbin/.common-env.sh
📚 Learning: 2025-10-13T03:32:19.293Z 
Learnt from: junhaoliao
Repo: y-scope/clp PR: 1414
File: tools/docker-images/clp-package/Dockerfile:20-24
Timestamp: 2025-10-13T03:32:19.293Z
Learning: In the clp repository's Dockerfiles (e.g., tools/docker-images/clp-package/Dockerfile), ENV directives should be split into separate lines for readability rather than consolidated to reduce layer count. This is especially true for PATH modifications, as agreed upon in PR #1166. Later ENV settings may depend on earlier ones (e.g., referencing CLP_HOME).

Applied to files:

  • components/package-template/src/sbin/.common-env.sh
📚 Learning: 2025-10-20T21:05:30.417Z 
Learnt from: junhaoliao
Repo: y-scope/clp PR: 1413
File: tools/docker-images/clp-package/Dockerfile:22-24
Timestamp: 2025-10-20T21:05:30.417Z
Learning: In the clp repository's Dockerfiles, ENV directives should be consolidated into multi-line ENV statements when possible to reduce image layers. ENV statements should only be split into separate commands when consolidation is not possible due to dependencies (e.g., when later variables must reference earlier ones that need to be set first, or when PATH must be modified sequentially).

Applied to files:

  • components/package-template/src/sbin/.common-env.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: package-image
  • GitHub Check: lint-check (ubuntu-24.04)
  • GitHub Check: lint-check (macos-15)
🔇 Additional comments (1)
components/package-template/src/sbin/.common-env.sh (1)

22-24: Approuver le changement de format d'étiquette d'image - vérification de cohérence réussie.

La suppression du préfixe « v » est cohérente avec le reste de la base de code. Une vérification complète confirme que :

  • Le code Python dans components/clp-py-utils/clp_py_utils/clp_config.py (ligne 799) construit déjà l'étiquette sans le préfixe « v » : ghcr.io/y-scope/clp/clp-package:{clp_package_version}
  • Aucune référence à l'ancien format avec « v » n'existe dans la base de code
  • Les fichiers docker-compose utilisent la variable CLP_PACKAGE_CONTAINER_IMAGE_REF qui sera correctement définie par le script modifié

La modification est sûre et alignée avec les modèles existants.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@junhaoliao junhaoliao self-requested a review November 10, 2025 05:26
@kirkrodrigues kirkrodrigues merged commit 8b997dd into y-scope:main Nov 10, 2025
21 checks passed
@kirkrodrigues kirkrodrigues deleted the fix-1576 branch November 10, 2025 06:34
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@kirkrodrigues
fix(clp-package): Remove v prefix from the package container image'…
99afceb 
…s version tag (fixes y-scope#1576). (y-scope#1577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kirkrodrigues @junhaoliao